From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Nadav Amit <namit@vmware.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
nadav.amit@gmail.com, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Denys Vlasenko <dvlasenk@redhat.com>
Subject: Re: [PATCH 2/6] x86: bug: prevent gcc distortions
Date: Fri, 18 May 2018 12:11:14 +0200 [thread overview]
Message-ID: <20180518101114.GB17285@pd.tnic> (raw)
In-Reply-To: <20180518081354.GA11379@gmail.com>
On Fri, May 18, 2018 at 10:13:54AM +0200, Ingo Molnar wrote:
> Yes, that's my main worry too about all these inlining changes:
> the very, very marked reduction in the readability of assembly code.
Same reaction here: the small improvements this brings is simply not
enough to sacrifice readability so much IMO.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-05-18 10:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 16:13 [PATCH 0/6] Macrofying inline assembly for better compilation Nadav Amit
2018-05-17 16:13 ` [PATCH 1/6] x86: objtool: use asm macro for better compiler decisions Nadav Amit
2018-05-17 16:13 ` [PATCH 2/6] x86: bug: prevent gcc distortions Nadav Amit
2018-05-18 7:58 ` Peter Zijlstra
2018-05-18 8:13 ` Ingo Molnar
2018-05-18 10:11 ` Borislav Petkov [this message]
2018-05-18 14:36 ` Nadav Amit
2018-05-18 15:40 ` Borislav Petkov
2018-05-18 15:46 ` Nadav Amit
2018-05-18 15:53 ` Borislav Petkov
2018-05-18 16:29 ` Nadav Amit
2018-05-18 17:41 ` Boris Petkov
2018-05-18 14:30 ` Nadav Amit
2018-05-18 14:22 ` Nadav Amit
2018-05-18 17:52 ` Joe Perches
2018-05-18 16:24 ` Linus Torvalds
2018-05-18 17:24 ` Nadav Amit
2018-05-18 18:25 ` Linus Torvalds
2018-05-18 18:33 ` hpa
2018-05-18 18:50 ` Linus Torvalds
2018-05-18 18:53 ` hpa
2018-05-18 19:02 ` Nadav Amit
2018-05-18 19:05 ` hpa
2018-05-18 19:11 ` Linus Torvalds
2018-05-18 19:18 ` Nadav Amit
2018-05-18 19:21 ` Linus Torvalds
2018-05-18 19:22 ` hpa
2018-05-18 19:36 ` Nadav Amit
2018-05-18 19:41 ` hpa
2018-05-17 16:13 ` [PATCH 3/6] x86: alternative: macrofy locks for better inlining Nadav Amit
2018-05-17 16:14 ` [PATCH 4/6] x86: prevent inline distortion by paravirt ops Nadav Amit
2018-05-17 16:14 ` [PATCH 5/6] x86: refcount: prevent gcc distortions Nadav Amit
2018-05-19 4:27 ` kbuild test robot
2018-05-17 16:14 ` [PATCH 6/6] x86: removing unneeded new-lines Nadav Amit
2018-05-18 9:20 ` [PATCH 0/6] Macrofying inline assembly for better compilation David Laight
2018-05-18 14:15 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518101114.GB17285@pd.tnic \
--to=bp@alien8.de \
--cc=a.p.zijlstra@chello.nl \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox