From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-4167094-1526657913-2-14990875128643402139 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.248, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='US-ASCII' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-api-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1526657912; b=g3My0VahnkDVtQHynH0dOSZaD6l+BbnoWIid0RelTZsjCc17Ot X9TcEA6QeamRZCIpPHhwy9MfCtdQjntYWj67s0HfmZE1lLGiKR/ZWlCL30+QU5M8 wYd2yV52xXnF1GwfcKxb2/rOdtZzfXOpW+OycCllOVCvW/HGqrZgN1qDIrqfTGS2 jybdfwN3tnqhNhgA75nN2rNcsW88bb9lzSFZVbwKJWf9aC0/rJUFLUOiSOI5VXhD q9h49DNibX9c3ZN8rTrLJ+C0Z2htD0XPOFgni8v3BGVDHsLrbD278tyPoHsKRwCD y09sJYJ/075j7nhKDCMegMk9mTpBxBi8GH+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-type :content-transfer-encoding:sender:list-id; s=fm2; t=1526657912; bh=URv80NhLXe6ANbQB2jTImrsjCyuyqU0COCwTvQe3X1E=; b=S4NtdFLDMTqm PQMQ2BINQWyAFxrFghOhvymEuI4tjeccGtdmoI+5NrtK4IcypcFZnkI7C/KE6ZAN 9ywcLzXt48m41siHu/r5vBg0zsACLNaqPA0w2wGxNwnK05kLQNRn+13zq7O4/xDj xOpUPV/oWnbb+U0pQJmDgQ8C4fBCcQx5vE7QtDYHA+PMxN90NabqUKneAzErOiLL 4I0qPmMC7U/38QlE0SWVoC/zSDsblpJrBhWB0CQewcinD6EqOXVP5QqPLEjoqen+ iGIPnB0v05u5nwCSLXbPVM6yc/G0i8Bg/mzQNI8bkohgDCWOrEge4lYd/x2x+TrV cIBjRWsQQA== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=redhat.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=redhat.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=redhat.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=redhat.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfAAzXDtVkfhTbzi+QqCg+2oPxiMT7EjOzhNDno4DdVBO8uk3dtC07a9wBB6QfXDu/KvyNbXrll5c9gEZA6H+o06BL5NCcklT+jVsXu6KwjNptsmX10I3 9paaTWWRBtMaUXYxWLmBrMKCWJb3V3Qh/jBNuWSGqEP0yYJbPzQLx3wK1toEfaO4PGu5ooxaqoautAJXPayK0N+vaW7mcrd2ZsoULHfAammgkn/xlh8eS4xf X-CM-Analysis: v=2.3 cv=E8HjW5Vl c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=kj9zAlcOel0A:10 a=VUJBJC2UJ8kA:10 a=20KFwNOVAAAA:8 a=VwQbUJbxAAAA:8 a=PQoj46ejlvtlZLVYNoAA:9 a=CjuIK1q_8ugA:10 a=x8gzFH9gYPwA:10 a=AjGcO6oz07-iQ99wixmX:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752338AbeERPi2 (ORCPT ); Fri, 18 May 2018 11:38:28 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33980 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751112AbeERPi0 (ORCPT ); Fri, 18 May 2018 11:38:26 -0400 Date: Fri, 18 May 2018 11:38:25 -0400 From: Steve Grubb To: Richard Guy Briggs Cc: cgroups@vger.kernel.org, containers@lists.linux-foundation.org, linux-api@vger.kernel.org, Linux-Audit Mailing List , linux-fsdevel@vger.kernel.org, LKML , netdev@vger.kernel.org, ebiederm@xmission.com, luto@kernel.org, jlayton@redhat.com, carlos@redhat.com, dhowells@redhat.com, viro@zeniv.linux.org.uk, simo@redhat.com, eparis@parisplace.org, serge@hallyn.com Subject: Re: [RFC PATCH ghak32 V2 01/13] audit: add container id Message-ID: <20180518113825.4ceeadf6@ivy-bridge> In-Reply-To: <20180518152106.do5b3mu6e6eyvo7q@madcap2.tricolour.ca> References: <20180517170053.7d4afa87@ivy-bridge> <20180517215600.dyswlkvqdtgjwr5y@madcap2.tricolour.ca> <20180518095636.56ff322d@ivy-bridge> <20180518152106.do5b3mu6e6eyvo7q@madcap2.tricolour.ca> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-api-owner@vger.kernel.org X-Mailing-List: linux-api@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, 18 May 2018 11:21:06 -0400 Richard Guy Briggs wrote: > On 2018-05-18 09:56, Steve Grubb wrote: > > On Thu, 17 May 2018 17:56:00 -0400 > > Richard Guy Briggs wrote: > > > > > > During syscall events, the path info is returned in a a record > > > > simply called AUDIT_PATH, cwd info is returned in AUDIT_CWD. So, > > > > rather than calling the record that gets attached to everything > > > > AUDIT_CONTAINER_INFO, how about simply AUDIT_CONTAINER. > > > > > > Considering the container initiation record is different than the > > > record to document the container involved in an otherwise normal > > > syscall, we need two names. I don't have a strong opinion what > > > they are. > > > > > > I'd prefer AUDIT_CONTAIN and AUDIT_CONTAINER_INFO so that the two > > > are different enough to be visually distinct while leaving > > > AUDIT_CONTAINERID for the field type in patch 4 ("audit: add > > > containerid filtering") > > (Sorry, I had intended AUDIT_CONTAINER for the first in that paragraph > above.) > > > How about AUDIT_CONTAINER for the auxiliary record? The one that > > starts the container, I don't have a strong opinion on. Could be > > AUDIT_CONTAINER_INIT, AUDIT_CONTAINER_START, AUDIT_CONTAINERID, > > AUDIT_CONTAINER_ID, or something else. The API call that sets the ID > > for filtering could be AUDIT_CID or AUDIT_CONTID if that helps > > decide what the initial event might be. Normally, it should match > > the field being filtered. > > Ok, I had shortened the record field name to "contid=" to be unique > enough while not using too much netlink bandwidth. I could have used > "cid=" but that could be unobvious or ambiguous. I didn't want to use > the full "containerid=" due to that. I suppose I could change the > field name macro to AUDIT_CONTID. > > For the one that starts the container, I'd prefer to leave the name a > bit more general than "_INIT", "_START", so maybe I'll swap them > around and use AUDIT_CONTAINER_INFO for the startup record, and use > AUDIT_CONTAINER for the syscall auxiliary record. > > Does that work? I'll go along with that. Thanks. But making that swap frees up AUDIT_CONTAINER_ID which could be the first event. But AUDIT_CONTAINER_INFO is also fine with me. Best Regards, -Steve