From: James Hogan <jhogan@kernel.org>
To: Mathias Kresin <dev@kresin.me>
Cc: john@phrozen.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org, martin.blumenstingl@googlemail.com,
hauke@hauke-m.de, stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: lantiq: gphy: Drop reboot/remove reset asserts
Date: Mon, 21 May 2018 17:39:33 +0100 [thread overview]
Message-ID: <20180521163932.GA12779@jamesdev> (raw)
In-Reply-To: <1523176203-18926-1-git-send-email-dev@kresin.me>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Sun, Apr 08, 2018 at 10:30:03AM +0200, Mathias Kresin wrote:
> While doing a global software reset, these bits are not cleared and let
> some bootloader fail to initialise the GPHYs. The bootloader don't
> expect the GPHYs in reset, as they aren't during power on.
>
> The asserts were a workaround for a wrong syscon-reboot mask. With a
> mask set which includes the GPHY resets, these resets aren't required
> any more.
>
> Fixes: 126534141b45 ("MIPS: lantiq: Add a GPHY driver which uses the RCU syscon-mfd")
> Cc: stable@vger.kernel.org # 4.14+
> Signed-off-by: Mathias Kresin <dev@kresin.me>
Applied for 4.17. Thanks for the acks/reviews folk!
Thanks
James
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2018-05-21 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 8:30 [PATCH] MIPS: lantiq: gphy: Drop reboot/remove reset asserts Mathias Kresin
2018-04-08 21:30 ` Martin Blumenstingl
2018-04-22 19:18 ` Hauke Mehrtens
2018-05-21 16:39 ` James Hogan [this message]
2018-05-24 12:07 ` James Hogan
2018-05-25 10:12 ` Mathias Kresin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521163932.GA12779@jamesdev \
--to=jhogan@kernel.org \
--cc=dev@kresin.me \
--cc=hauke@hauke-m.de \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox