Re: [PATCH v5 01/13] KVM: s390: Interface to test whether APXA installed

Cornelia Huck
2018-05-17T09:44:30Z

On Thu, 17 May 2018 11:11:41 +0200
Harald Freudenberger <freude@linux.ibm.com> wrote:

> On 16.05.2018 12:45, Tony Krowiak wrote:
> > On 05/16/2018 06:21 AM, Cornelia Huck wrote:
> >> On Mon,  7 May 2018 11:11:40 -0400
> >> Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote:
> >>
> >>> Relocates an existing static function that tests whether
> >>> the AP extended addressing facility (APXA) is installed on
> >>> the linux host. The primary reason for relocating this
> >>> function is because a new compilation unit (arch/s390/kvm/kvm-ap.c)
> >>> is being created to contain all of the interfaces and logic
> >>> for configuring an AP matrix for a KVM guest. Some of its
> >>> functions will also need to determine whether APXA is installed,
> >>> so, let's go ahead and relocate this static function as a
> >>> public interface in kvm-ap.c.
> >>>
> >>> Notes:
> >>> ----
> >>> 1. The interface to determine whether APXA is installed on the linux
> >>>     host the information returned from the AP Query Configuration
> >>>     Information (QCI) function. This function will not be available
> >>>     if the AP instructions are not installed on the linux host, so a check
> >>>     will be included to verify that.
> >>>
> >>> 2. Currently, the AP bus interfaces accessing the AP instructions will
> >>>     not be accessible if CONFIG_ZCRYPT=n, so the relevant code will be
> >>>     temporarily contained in the new arch/s390/kvm/kvm-ap.c file until
> >>>     the patch(es) to statically build the required AP bus interfaces are
> >>>     available.
> >> Any ETA for those interfaces? Would be nice if we could avoid
> >> introducing temporary interfaces (but I'm certainly not opposing this
> >> patch).
> >
> > I'll check with the developer.
> The proposal is out on the internal mailing list. I'd like to release it (internal) tomorrow or start
> next week. Already talked with Christian about this because we need to align it somehow with
> kvm and s390 kernel development.

Great, thanks for the update!