From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751942AbeEVRhy (ORCPT ); Tue, 22 May 2018 13:37:54 -0400 Received: from mail-yb0-f194.google.com ([209.85.213.194]:40755 "EHLO mail-yb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbeEVRhw (ORCPT ); Tue, 22 May 2018 13:37:52 -0400 X-Google-Smtp-Source: AB8JxZrNWnaMm2xOHnASZ9x2ZC7kSkXzNj2mlWsI1jvU+95LES0t/urIaDP2Sy69N02Zf5E2+mnNyw== Date: Tue, 22 May 2018 12:37:50 -0500 From: Rob Herring To: Elaine Zhang Cc: heiko@sntech.de, mark.rutland@arm.com, devicetree@vger.kernel.org, rjw@rjwysocki.net, khilman@kernel.org, ulf.hansson@linaro.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, wxt@rock-chips.com, xxx@rock-chips.com, xf@rock-chips.com, huangtao@rock-chips.com Subject: Re: [PATCH v2 08/13] dt-bindings: power: add RK3228 SoCs header for power-domain Message-ID: <20180522173750.GA17538@rob-hp-laptop> References: <1526268455-9133-1-git-send-email-zhangqing@rock-chips.com> <1526268668-20006-1-git-send-email-zhangqing@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526268668-20006-1-git-send-email-zhangqing@rock-chips.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 14, 2018 at 11:31:08AM +0800, Elaine Zhang wrote: > According to a description from TRM, add all the power domains. > > Signed-off-by: Elaine Zhang > --- > include/dt-bindings/power/rk3228-power.h | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 include/dt-bindings/power/rk3228-power.h > > diff --git a/include/dt-bindings/power/rk3228-power.h b/include/dt-bindings/power/rk3228-power.h > new file mode 100644 > index 000000000000..fa1264d5a995 > --- /dev/null > +++ b/include/dt-bindings/power/rk3228-power.h > @@ -0,0 +1,26 @@ > +/* > + * Copyright (c) 2018 Fuzhou Rockchip Electronics Co., Ltd > + * > + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) This goes on the first line. checkpatch.pl will tell you this. The license here is different than all the others, was that the intent? > + */ > + > +#ifndef __DT_BINDINGS_POWER_RK3228_POWER_H__ > +#define __DT_BINDINGS_POWER_RK3228_POWER_H__ > + > +/** > + * RK3228 idle id Summary. > + */ > + > +#define RK3228_PD_CORE 0 > +#define RK3228_PD_MSCH 1 > +#define RK3228_PD_BUS 2 > +#define RK3228_PD_SYS 3 > +#define RK3228_PD_VIO 4 > +#define RK3228_PD_VOP 5 > +#define RK3228_PD_VPU 6 > +#define RK3228_PD_RKVDEC 7 > +#define RK3228_PD_GPU 8 > +#define RK3228_PD_PERI 9 > +#define RK3228_PD_GMAC 10 > + > +#endif > -- > 1.9.1 > >