From: Joel Fernandes <joel@joelfernandes.org>
To: "Joel Fernandes (Google)" <joelaf@google.com>
Cc: linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Juri Lelli <juri.lelli@redhat.com>,
Luca Abeni <luca.abeni@santannapisa.it>,
Todd Kjos <tkjos@google.com>,
claudio@evidence.eu.com, kernel-team@android.com,
linux-pm@vger.kernel.org
Subject: Re: [PATCH RFC] schedutil: Address the r/w ordering race in kthread
Date: Tue, 22 May 2018 17:18:08 -0700 [thread overview]
Message-ID: <20180523001808.GC55359@joelaf.mtv.corp.google.com> (raw)
In-Reply-To: <20180522235028.80564-1-joel@joelfernandes.org>
On Tue, May 22, 2018 at 04:50:28PM -0700, Joel Fernandes (Google) wrote:
> Currently there is a race in schedutil code for slow-switch single-CPU
> systems. Fix it by enforcing ordering the write to work_in_progress to
> happen before the read of next_freq.
Aargh, s/before/after/.
Commit log has above issue but code is Ok. Should I resend this patch or
are there any additional comments? thanks!
- Joel
[..]
next prev parent reply other threads:[~2018-05-23 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 23:50 [PATCH RFC] schedutil: Address the r/w ordering race in kthread Joel Fernandes (Google)
2018-05-23 0:18 ` Joel Fernandes [this message]
2018-05-23 6:47 ` Juri Lelli
2018-05-23 8:23 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523001808.GC55359@joelaf.mtv.corp.google.com \
--to=joel@joelfernandes.org \
--cc=claudio@evidence.eu.com \
--cc=joelaf@google.com \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox