From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Alexei Starovoitov <ast@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>, <daniel@iogearbox.net>,
<torvalds@linux-foundation.org>, <gregkh@linuxfoundation.org>,
<luto@amacapital.net>, <mcgrof@kernel.org>,
<keescook@chromium.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH v3 net-next 0/2] bpfilter
Date: Wed, 23 May 2018 18:50:33 -0700 [thread overview]
Message-ID: <20180523185010.0490e7ec@cakuba> (raw)
In-Reply-To: <20180523183352.7ccc3f5d@cakuba>
[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]
On Wed, 23 May 2018 18:33:52 -0700, Jakub Kicinski wrote:
> Minor glitch with Ubuntu 18.04:
>
> $ gcc --version
> gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
>
> In file included from /usr/include/fcntl.h:290:0,
> from ../net/bpfilter/main.c:7:
> In function ‘open’,
> inlined from ‘main’ at ../net/bpfilter/main.c:58:13:
> /usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:4: error: call to ‘__open_missing_mode’ declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments
> __open_missing_mode ();
> ^~~~~~~~~~~~~~~~~~~~~~
> scripts/Makefile.host:107: recipe for target 'net/bpfilter/main.o' failed
> make[3]: *** [net/bpfilter/main.o] Error 1
>
> I can't repro on Fedora 27 gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5),
> perhaps the GCC is broken on that Ubuntu 18.04 box of mine. The warning/
> /error, however, looks potentially legit?
More?
Kernel: arch/x86/boot/bzImage is ready (#9)
Building modules, stage 2.
MODPOST 1620 modules
ERROR: "bpfilter_process_sockopt" [net/bpfilter/bpfilter.ko] undefined!
../scripts/Makefile.modpost:92: recipe for target '__modpost' failed
make[2]: *** [__modpost] Error 1
/home/jkicinski/devel/linux/Makefile:1274: recipe for target 'modules' failed
make[1]: *** [modules] Error 2
make[1]: Leaving directory '/home/jkicinski/devel/linux/build_randconfig'
Makefile:146: recipe for target 'sub-make' failed
make: *** [sub-make] Error 2
[-- Attachment #2: bpfitlter_config.bz2 --]
[-- Type: application/x-bzip, Size: 30187 bytes --]
next prev parent reply other threads:[~2018-05-24 1:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 2:22 [PATCH v3 net-next 0/2] bpfilter Alexei Starovoitov
2018-05-22 2:22 ` [PATCH v3 net-next 1/2] umh: introduce fork_usermode_blob() helper Alexei Starovoitov
2018-05-22 2:22 ` [PATCH v3 net-next 2/2] net: add skeleton of bpfilter kernel module Alexei Starovoitov
2018-05-23 17:26 ` [PATCH v3 net-next 0/2] bpfilter David Miller
2018-05-23 17:33 ` Greg KH
2018-05-24 1:33 ` Jakub Kicinski
2018-05-24 1:50 ` Jakub Kicinski [this message]
2018-05-24 2:09 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523185010.0490e7ec@cakuba \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox