From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: Joel Fernandes <joelaf@google.com>,
linux-kernel@vger.kernel.org, Boqun Feng <boqun.feng@gmail.com>,
byungchul.park@lge.com, Ingo Molnar <mingo@redhat.com>,
Josh Triplett <josh@joshtriplett.org>,
kernel-team@android.com, Lai Jiangshan <jiangshanlai@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Peter Zilstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 3/4] rcu: Use better variable names in funnel locking loop
Date: Wed, 23 May 2018 18:27:55 -0700 [thread overview]
Message-ID: <20180524012755.GI3803@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180524005450.GA171060@joelaf.mtv.corp.google.com>
On Wed, May 23, 2018 at 05:54:50PM -0700, Joel Fernandes wrote:
> On Wed, May 23, 2018 at 12:23:49PM -0700, Paul E. McKenney wrote:
> > On Wed, May 23, 2018 at 09:06:17AM -0700, Paul E. McKenney wrote:
> > > On Tue, May 22, 2018 at 11:38:14PM -0700, Joel Fernandes wrote:
> > > > From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
> > > >
> > > > The funnel locking loop in rcu_start_this_gp uses rcu_root as a
> > > > temporary variable while walking the combining tree. This causes a
> > > > tiresome exercise of a code reader reminding themselves that rcu_root
> > > > may not be root. Lets just call it rnp, and rename other variables as
> > > > well to be more appropriate.
> > > >
> > > > Original patch: https://patchwork.kernel.org/patch/10396577/
> > > >
> > > > Signed-off-by: Joel Fernandes <joel@joelfernandes.org>
> > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> > >
> > > I used to have double Signed-off-by back when I was seconded to Linaro.
> > > But I am guessing that you want the second and don't need the first
> > > one. Unless you tell me otherwise, I will remove the first one on
> > > my next rebase.
> > >
> > > Anyway, the new variable names are much more clear, good stuff,
> > > queued for further review and testing, thank you!
> >
> > And it looks to me like I should fold in the patchlet below to change to
> > rnp_start in a comment. Please let me know if this would mess things up.
>
> Yes, missed that. Sorry. It looks great, thanks!
Done! And not a problem -- this is after all why we do reviews.
Thanx, Paul
next prev parent reply other threads:[~2018-05-24 3:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 6:38 [PATCH 0/4] cleanups, fixes for rcu/dev Joel Fernandes
2018-05-23 6:38 ` [PATCH 1/4] rcu: Speed up calling of RCU tasks callbacks Joel Fernandes
2018-05-23 15:57 ` Paul E. McKenney
2018-05-23 16:45 ` Steven Rostedt
2018-05-23 17:03 ` Paul E. McKenney
2018-05-23 19:13 ` Steven Rostedt
2018-05-23 20:04 ` Paul E. McKenney
2018-05-23 21:51 ` Joel Fernandes
2018-05-24 0:51 ` Joel Fernandes
2018-05-24 1:35 ` Steven Rostedt
2018-05-24 21:47 ` Steven Rostedt
2018-05-24 22:38 ` Paul E. McKenney
2018-05-24 22:42 ` Steven Rostedt
2018-07-17 9:11 ` [tip:core/rcu] rcu: Add comment to the last sleep in the rcu tasks loop tip-bot for Steven Rostedt (VMware)
2018-07-17 9:11 ` [tip:core/rcu] rcu: Speed up calling of RCU tasks callbacks tip-bot for Steven Rostedt (VMware)
2018-05-23 6:38 ` [PATCH 2/4] rcu: Add comment documenting how rcu_seq_snap works Joel Fernandes
2018-05-23 16:04 ` Paul E. McKenney
2018-05-23 6:38 ` [PATCH 3/4] rcu: Use better variable names in funnel locking loop Joel Fernandes
2018-05-23 16:06 ` Paul E. McKenney
2018-05-23 19:23 ` Paul E. McKenney
2018-05-24 0:54 ` Joel Fernandes
2018-05-24 1:27 ` Paul E. McKenney [this message]
2018-05-23 6:38 ` [PATCH 4/4] rcu: Identify grace period is in progress as we advance up the tree Joel Fernandes
2018-05-23 16:06 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524012755.GI3803@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=boqun.feng@gmail.com \
--cc=byungchul.park@lge.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=joelaf@google.com \
--cc=josh@joshtriplett.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).