From: Peter Zijlstra <peterz@infradead.org>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
linux-arm-kernel@lists.infradead.org,
yamada.masahiro@socionext.com
Subject: Re: [PATCH 6/9] asm-generic/bitops/atomic.h: Rewrite using atomic_fetch_*
Date: Thu, 24 May 2018 14:44:10 +0200 [thread overview]
Message-ID: <20180524124410.GF12198@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1527159586-8578-7-git-send-email-will.deacon@arm.com>
On Thu, May 24, 2018 at 11:59:43AM +0100, Will Deacon wrote:
> +static inline void set_bit(unsigned int nr, volatile unsigned long *p)
> {
> + p += BIT_WORD(nr);
> + atomic_long_fetch_or_relaxed(BIT_MASK(nr), (atomic_long_t *)p);
> }
>
> +static inline void clear_bit(unsigned int nr, volatile unsigned long *p)
> {
> + p += BIT_WORD(nr);
> + atomic_long_fetch_andnot_relaxed(BIT_MASK(nr), (atomic_long_t *)p);
> }
>
> +static inline void change_bit(unsigned int nr, volatile unsigned long *p)
> {
> + p += BIT_WORD(nr);
> + atomic_long_fetch_xor_relaxed(BIT_MASK(nr), (atomic_long_t *)p);
> }
Why use the fetch variants here?
next prev parent reply other threads:[~2018-05-24 12:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 10:59 [PATCH 0/9] Rewrite asm-generic/bitops/{atomic,lock}.h and use on arm64 Will Deacon
2018-05-24 10:59 ` [PATCH 1/9] h8300: Don't include linux/kernel.h in asm/atomic.h Will Deacon
2018-07-22 13:58 ` Yoshinori Sato
2018-05-24 10:59 ` [PATCH 2/9] m68k: Don't use asm-generic/bitops/lock.h Will Deacon
2018-05-24 10:59 ` [PATCH 3/9] asm-generic: Move some macros from linux/bitops.h to a new bits.h file Will Deacon
2018-05-24 10:59 ` [PATCH 4/9] openrisc: Don't pull in all of linux/bitops.h in asm/cmpxchg.h Will Deacon
2018-05-24 10:59 ` [PATCH 5/9] sh: Don't pull in all of linux/bitops.h in asm/cmpxchg-xchg.h Will Deacon
2018-05-24 10:59 ` [PATCH 6/9] asm-generic/bitops/atomic.h: Rewrite using atomic_fetch_* Will Deacon
2018-05-24 12:44 ` Peter Zijlstra [this message]
2018-05-24 12:47 ` Will Deacon
2018-05-24 13:09 ` Mark Rutland
2018-05-24 22:06 ` Andrea Parri
2018-05-24 22:32 ` Peter Zijlstra
2018-05-24 10:59 ` [PATCH 7/9] asm-generic/bitops/lock.h: " Will Deacon
2018-05-24 10:59 ` [PATCH 8/9] arm64: Replace our atomic/lock bitop implementations with asm-generic Will Deacon
2018-05-24 10:59 ` [PATCH 9/9] arm64: bitops: Include <asm-generic/bitops/ext2-atomic-setbit.h> Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524124410.GF12198@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox