Re: [PATCH v2] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0

Linus Walleij
2018-05-24T08:20:02Z

On Tue, May 22, 2018 at 10:47 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:

> As Google/Intel will fix the BIOS/Coreboot issues with hardcoding
> virtual interrupt numbers for keyboard/touchpad/touchscreen controllers
> in ACPI tables, they will also update BOARD version number from 1.0
> to 1.1. Let's limit the DMI quirks that try to preserve virtual IRQ
> numbers on Strago boards to those that still carry older BIOSes.
>
> Note that ideally not BOARD but BIOS version should have been updated.
> However the BIOS version used by Chrome devices has format of
> Google_BUILD.BRANCH.PATCH which is not well suited for DMI matching as
> we do not have "less than" match mode for DMI data.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> v1->v2:
>
> - switch from matching on DMI_BIOS_VERSION to DMI_BOARD_VERSION

Patch applied for fixes.

Should this also be tagged for stable?

Yours,
Linus Walleij