From: Mark Brown <broonie@kernel.org>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc: "mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Mutanen, Mikko" <Mikko.Mutanen@fi.rohmeurope.com>,
"Haikola, Heikki" <Heikki.Haikola@fi.rohmeurope.com>
Subject: Re: [PATCH 8/9] regulator: bd71837: BD71837 PMIC regulator driver
Date: Thu, 24 May 2018 18:59:40 +0100 [thread overview]
Message-ID: <20180524175940.GC4828@sirena.org.uk> (raw)
In-Reply-To: <042F8805D2046347BB8420BEAE397A4016C06B60@WILL-MAIL002.REu.RohmEu.com>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Thu, May 24, 2018 at 05:51:27PM +0000, Vaittinen, Matti wrote:
> > what is the lock doing and what is this wrapper function intended to do?
> This was the other spot which I was unsure how to handle. Datasheet for
> the chip says that if voltage is to be changed, the regulator must be
> disabled. Thus my voltage changing function checks if regulator is enabled
Ugh, this chip is not very good is it? Don't bounce the supply to
change the voltage silently, that's clearly a bad idea - the devices
using the supply are going to get very upset when the power gets removed
just because they changed the voltage. Instead implement a custom set
operation that returns an error if the user attempts to change the
voltage while the regualtor is enabled.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-05-24 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 6:00 [PATCH 8/9] regulator: bd71837: BD71837 PMIC regulator driver Matti Vaittinen
2018-05-24 14:14 ` Mark Brown
2018-05-24 17:51 ` Vaittinen, Matti
2018-05-24 17:59 ` Mark Brown [this message]
2018-05-25 5:08 ` Matti Vaittinen
2018-05-25 7:22 ` Matti Vaittinen
2018-05-25 10:14 ` Mark Brown
2018-05-25 11:32 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524175940.GC4828@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Heikki.Haikola@fi.rohmeurope.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=Mikko.Mutanen@fi.rohmeurope.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox