From: David Miller <davem@davemloft.net>
To: jmaxwell37@gmail.com
Cc: dsahern@gmail.com, mschiffer@universe-factory.net,
zhangshengju@cmss.chinamobile.com, ktkhai@virtuozzo.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jmaxwell@redhat.com
Subject: Re: [PATCH net-next] ifb: fix packets checksum
Date: Fri, 25 May 2018 16:43:37 -0400 (EDT) [thread overview]
Message-ID: <20180525.164337.1433478215018599363.davem@davemloft.net> (raw)
In-Reply-To: <20180524213829.15208-1-jmaxwell37@gmail.com>
From: Jon Maxwell <jmaxwell37@gmail.com>
Date: Fri, 25 May 2018 07:38:29 +1000
> Fixup the checksum for CHECKSUM_COMPLETE when pulling skbs on RX path.
> Otherwise we get splats when tc mirred is used to redirect packets to ifb.
>
> Before fix:
>
> nic: hw csum failure
>
> Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
This definitely seems correct, but I am really surprised a bug like this has
lasted as long as it has.
So I'll let this sit for another day or two for review.
next prev parent reply other threads:[~2018-05-25 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 21:38 [PATCH net-next] ifb: fix packets checksum Jon Maxwell
2018-05-25 20:43 ` David Miller [this message]
2018-05-28 23:13 ` Jonathan Maxwell
2018-05-29 3:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525.164337.1433478215018599363.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jmaxwell37@gmail.com \
--cc=jmaxwell@redhat.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).