From: Mark Brown <broonie@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Mutanen, Mikko" <Mikko.Mutanen@fi.rohmeurope.com>,
"Haikola, Heikki" <Heikki.Haikola@fi.rohmeurope.com>
Subject: Re: [PATCH 8/9] regulator: bd71837: BD71837 PMIC regulator driver
Date: Fri, 25 May 2018 11:14:23 +0100 [thread overview]
Message-ID: <20180525101423.GH4828@sirena.org.uk> (raw)
In-Reply-To: <20180525072253.GC16888@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On Fri, May 25, 2018 at 10:22:53AM +0300, Matti Vaittinen wrote:
> On Thu, May 24, 2018 at 05:51:27PM +0000, Vaittinen, Matti wrote:
> > > devm_regulator_regster()
> > Makes sense. Thanks
> I was going to do
> - pmic = kzalloc(sizeof(struct bd71837_pmic), GFP_KERNEL);
> + pmic = devm_kzalloc(&pdev->dev, sizeof(struct bd71837_pmic),
> + GFP_KERNEL);
> and
> - rdev = regulator_register(desc, &config);
> + rdev = devm_regulator_register(&pdev->dev, desc, &config);
>
> but is there now a race regarding freeing the pmic structure and
> unregistering the regulator?
Why? devm_ stuff gets unwound in the opposite order to the order in
which it was allocated.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
next prev parent reply other threads:[~2018-05-25 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 6:00 [PATCH 8/9] regulator: bd71837: BD71837 PMIC regulator driver Matti Vaittinen
2018-05-24 14:14 ` Mark Brown
2018-05-24 17:51 ` Vaittinen, Matti
2018-05-24 17:59 ` Mark Brown
2018-05-25 5:08 ` Matti Vaittinen
2018-05-25 7:22 ` Matti Vaittinen
2018-05-25 10:14 ` Mark Brown [this message]
2018-05-25 11:32 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525101423.GH4828@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Heikki.Haikola@fi.rohmeurope.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=Mikko.Mutanen@fi.rohmeurope.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox