Re: [PATCH] drm: check_pixel_format() should return true if no modifiers are passed for a supported pixel format

Ville Syrjälä
2018-05-25T15:55:04Z

On Fri, May 25, 2018 at 04:35:41PM +0100, Ayan Kumar Halder wrote:
> If a plane supports a pixel format and the framebuffer does not pass any
> modifiers, then drm_plane_check_pixel_format() should always return true
> for the given format regardless of whether the plane supports any
> modifiers or not.

If your plane supports DRM_FORMAT_MOD_LINEAR then you should add that
to the plane's modifier list.

>
> Signed-off-by: Ayan Kumar Halder <ayan.halder@arm.com>
> ---
> drivers/gpu/drm/drm_plane.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
> index 6d2a6e4..873c084 100644
> --- a/drivers/gpu/drm/drm_plane.c
> +++ b/drivers/gpu/drm/drm_plane.c
> @@ -564,6 +564,9 @@ int drm_plane_check_pixel_format(struct drm_plane *plane,
> if (!plane->modifier_count)
> return 0;
>
> + if (modifier == DRM_FORMAT_MOD_NONE)
> + return 0;
> +
> for (i = 0; i < plane->modifier_count; i++) {
> if (modifier == plane->modifiers[i])
> break;
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Ville Syrjälä
Intel