From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934171AbeE0Fs7 (ORCPT ); Sun, 27 May 2018 01:48:59 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:45741 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932115AbeE0Fs6 (ORCPT ); Sun, 27 May 2018 01:48:58 -0400 X-Google-Smtp-Source: ADUXVKILeVubCUlrwsywHZ00DdFe9IrfJRVmTszoGiJgkvzKHkM3i3OJ9X505kasiIbzzbLxZ5+YWg== Date: Sun, 27 May 2018 07:48:47 +0200 From: Marcus Folkesson To: Greg Kroah-Hartman Cc: Jonathan Corbet , Felipe Balbi , davem@davemloft.net, Mauro Carvalho Chehab , Andrew Morton , Randy Dunlap , Ruslan Bilovol , Thomas Gleixner , Kate Stewart , linux-usb@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device Message-ID: <20180527054847.GB22105@gmail.com> References: <20180526203401.16586-1-marcus.folkesson@gmail.com> <20180526205652.GA25534@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180526205652.GA25534@kroah.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 26, 2018 at 10:56:52PM +0200, Greg Kroah-Hartman wrote: > On Sat, May 26, 2018 at 10:33:59PM +0200, Marcus Folkesson wrote: > > Signed-off-by: Marcus Folkesson > > I can't take patches without any changelog text. And why would you > submit a patch over 1000 lines without any? I'm sorry, obviously not much went well for me yesterday. The changlelog was "fixup:ed" away and now I noticed that my patch version history did not follow for v2. Is it better to send a v3 with updated version history or wait for more comments? I'll start review my patches better before sending them. Thank you for your time and comments. > > Please fix. > > thanks, > > greg k-h