From: Jonathan Cameron <jic23@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Quentin Schulz <quentin.schulz@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Mark Brown <broonie@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: sun4i-gpadc: select REGMAP_IRQ
Date: Sun, 27 May 2018 10:35:20 +0100 [thread overview]
Message-ID: <20180527103520.134fb6f8@archlinux> (raw)
In-Reply-To: <20180525153451.3164970-1-arnd@arndb.de>
On Fri, 25 May 2018 17:34:23 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> We can't call regmap_irq_get_virq() unless the regmap-irq support
> is enabled:
>
> drivers/iio/adc/sun4i-gpadc-iio.o: In function `sun4i_irq_init':
> sun4i-gpadc-iio.c:(.text+0x59c): undefined reference to `regmap_irq_get_virq'
>
> I came across this in a randconfig build now, but I guess this is
> a much older problem that I simply never hit before because regmap_irq
> is usually enabled by one of the other drivers that need it.
>
> Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to the togreg branch of iio.git. I might move it to the fixes
branch if the merge window opens shortly so as to get it upstream
faster. Pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 9da79070357c..13922b595503 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -717,6 +717,7 @@ config SUN4I_GPADC
> depends on IIO
> depends on MFD_SUN4I_GPADC || MACH_SUN8I
> depends on THERMAL || !THERMAL_OF
> + select REGMAP_IRQ
> help
> Say yes here to build support for Allwinner (A10, A13 and A31) SoCs
> GPADC. This ADC provides 4 channels which can be used as an ADC or as
prev parent reply other threads:[~2018-05-27 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 15:34 [PATCH] iio: adc: sun4i-gpadc: select REGMAP_IRQ Arnd Bergmann
2018-05-27 9:35 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180527103520.134fb6f8@archlinux \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=pmeerw@pmeerw.net \
--cc=quentin.schulz@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).