* [PATCH] iio: adc: sun4i-gpadc: select REGMAP_IRQ
@ 2018-05-25 15:34 Arnd Bergmann
2018-05-27 9:35 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-05-25 15:34 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Quentin Schulz, Chen-Yu Tsai, Maxime Ripard, Arnd Bergmann,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Mark Brown, linux-iio, linux-kernel
We can't call regmap_irq_get_virq() unless the regmap-irq support
is enabled:
drivers/iio/adc/sun4i-gpadc-iio.o: In function `sun4i_irq_init':
sun4i-gpadc-iio.c:(.text+0x59c): undefined reference to `regmap_irq_get_virq'
I came across this in a randconfig build now, but I guess this is
a much older problem that I simply never hit before because regmap_irq
is usually enabled by one of the other drivers that need it.
Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 9da79070357c..13922b595503 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -717,6 +717,7 @@ config SUN4I_GPADC
depends on IIO
depends on MFD_SUN4I_GPADC || MACH_SUN8I
depends on THERMAL || !THERMAL_OF
+ select REGMAP_IRQ
help
Say yes here to build support for Allwinner (A10, A13 and A31) SoCs
GPADC. This ADC provides 4 channels which can be used as an ADC or as
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: adc: sun4i-gpadc: select REGMAP_IRQ
2018-05-25 15:34 [PATCH] iio: adc: sun4i-gpadc: select REGMAP_IRQ Arnd Bergmann
@ 2018-05-27 9:35 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2018-05-27 9:35 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Quentin Schulz, Chen-Yu Tsai, Maxime Ripard, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Mark Brown, linux-iio,
linux-kernel
On Fri, 25 May 2018 17:34:23 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> We can't call regmap_irq_get_virq() unless the regmap-irq support
> is enabled:
>
> drivers/iio/adc/sun4i-gpadc-iio.o: In function `sun4i_irq_init':
> sun4i-gpadc-iio.c:(.text+0x59c): undefined reference to `regmap_irq_get_virq'
>
> I came across this in a randconfig build now, but I guess this is
> a much older problem that I simply never hit before because regmap_irq
> is usually enabled by one of the other drivers that need it.
>
> Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to the togreg branch of iio.git. I might move it to the fixes
branch if the merge window opens shortly so as to get it upstream
faster. Pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 9da79070357c..13922b595503 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -717,6 +717,7 @@ config SUN4I_GPADC
> depends on IIO
> depends on MFD_SUN4I_GPADC || MACH_SUN8I
> depends on THERMAL || !THERMAL_OF
> + select REGMAP_IRQ
> help
> Say yes here to build support for Allwinner (A10, A13 and A31) SoCs
> GPADC. This ADC provides 4 channels which can be used as an ADC or as
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-27 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-25 15:34 [PATCH] iio: adc: sun4i-gpadc: select REGMAP_IRQ Arnd Bergmann
2018-05-27 9:35 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).