Re: [PATCH 4.16 000/272] 4.16.13-stable review

Naresh Kamboju
2018-05-28T20:10:28Z

On 28 May 2018 at 15:30, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> This is the start of the stable review cycle for the 4.16.13 release.
> There are 272 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed May 30 10:01:02 UTC 2018.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.16.13-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.16.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> Davidlohr Bueso <dave@stgolabs.net>
> ipc/shm: fix shmat() nil address after round-down when remapping
>
> Davidlohr Bueso <dave@stgolabs.net>
> Revert "ipc/shm: Fix shmat mmap nil-page protection"

Regression on 4.16, 4,14, 4.9 and 4.4 and all devices.

Regressions (compared to build v4.16.12)
------------------------------------------------------------------------

On all devices,
ltp-syscalls-tests:
* cve-2017-5669

ltp-cve-tests:
* cve-2017-5669

Test log:
------------
cve-2017-5669.c:62: INFO: Attempting to attach shared memory to null page
cve-2017-5669.c:74: INFO: Mapped shared memory to (nil)
cve-2017-5669.c:78: FAIL: We have mapped a VM address within the first 64Kb
cve-2017-5669.c:84: INFO: Touching shared memory to see if anything
strange happens
Summary:
passed 0
failed 1
skipped 0
warnings 0

The root cause is,
"Revert "ipc/shm: Fix shmat mmap nil-page protection"",
which explicitly rolls back the original change and mentions that
the LTP test case needs to be updated accordingly.

This regression initially detected on 4.17.0-rc5-next-20180516
Need more investigation on this issue.

Ref:
LKFT: next: LTS-4.16,4.14 and 4.9: LTP test case cve-2017-5669 failed on
all devices
https://bugs.linaro.org/show_bug.cgi?id=3835
https://bugzilla.kernel.org/show_bug.cgi?id=192931
https://patchwork.kernel.org/patch/9552307/

Best regards
Naresh Kamboju