From: Juri Lelli <juri.lelli@redhat.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <Morten.Rasmussen@arm.com>,
viresh kumar <viresh.kumar@linaro.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Quentin Perret <quentin.perret@arm.com>
Subject: Re: [PATCH v5 08/10] cpufreq/schedutil: take into account interrupt
Date: Mon, 28 May 2018 14:37:30 +0200 [thread overview]
Message-ID: <20180528123730.GC1293@localhost.localdomain> (raw)
In-Reply-To: <CAKfTPtAn6F6J9=KFJrG_fMMeGvTn3abn1sMAdjpQMKLz0p9egA@mail.gmail.com>
On 28/05/18 14:06, Vincent Guittot wrote:
> Hi Juri,
>
> On 28 May 2018 at 12:41, Juri Lelli <juri.lelli@redhat.com> wrote:
> > Hi Vincent,
> >
> > On 25/05/18 15:12, Vincent Guittot wrote:
> >> The time spent under interrupt can be significant but it is not reflected
> >> in the utilization of CPU when deciding to choose an OPP. Now that we have
> >> access to this metric, schedutil can take it into account when selecting
> >> the OPP for a CPU.
> >> The CPU utilization is :
> >> irq util_avg + (1 - irq util_avg / max capacity ) * /Sum rq util_avg
> >
> > IIUC the code below you actually propose that
> >
> > util = [(max_cap - util_irq) * util_rq] / max_cap + util_irq
> >
> > where
> >
> > util_rq = /Sum rq util_avg
> > util_irq = irq util_avg
> >
> > So, which one is what you have in mind? Or am I wrong? :)
>
> mmh ... aren't they equal ?
>
> util = [(max_cap - util_irq) * util_rq] / max_cap + util_irq
> util = [(max_cap/max_cap - util_irq/max_cap) * util_rq] + util_irq
> util = [(1 - util_irq/max_cap) * util_rq] + util_irq
> util = util_irq + [(1 - util_irq/max_cap) * util_rq]
Ah, indeed.
next prev parent reply other threads:[~2018-05-28 12:37 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 13:12 [PATCH v5 00/10] track CPU utilization Vincent Guittot
2018-05-25 13:12 ` [PATCH v5 01/10] sched/pelt: Move pelt related code in a dedicated file Vincent Guittot
2018-05-25 14:26 ` Quentin Perret
2018-05-25 16:14 ` Peter Zijlstra
2018-05-29 8:21 ` Quentin Perret
2018-05-25 18:04 ` Patrick Bellasi
2018-05-29 14:55 ` Quentin Perret
2018-05-29 15:02 ` Vincent Guittot
2018-05-29 15:04 ` Quentin Perret
2018-05-25 13:12 ` [PATCH v5 02/10] sched/rt: add rt_rq utilization tracking Vincent Guittot
2018-05-25 15:54 ` Patrick Bellasi
2018-05-29 13:29 ` Vincent Guittot
2018-05-30 9:32 ` Patrick Bellasi
2018-05-30 10:06 ` Vincent Guittot
2018-05-30 11:01 ` Patrick Bellasi
2018-05-30 14:39 ` Vincent Guittot
2018-05-25 13:12 ` [PATCH v5 03/10] cpufreq/schedutil: add rt " Vincent Guittot
2018-05-30 7:03 ` Viresh Kumar
2018-05-30 8:23 ` Vincent Guittot
2018-05-30 9:40 ` Patrick Bellasi
2018-05-30 9:53 ` Vincent Guittot
2018-05-30 16:46 ` Quentin Perret
2018-05-31 8:46 ` Juri Lelli
2018-06-01 16:23 ` Peter Zijlstra
2018-06-01 17:23 ` Patrick Bellasi
2018-06-04 10:17 ` Quentin Perret
2018-06-04 15:16 ` Patrick Bellasi
2018-05-25 13:12 ` [PATCH v5 04/10] sched/dl: add dl_rq " Vincent Guittot
2018-05-30 10:50 ` Patrick Bellasi
2018-05-30 11:51 ` Vincent Guittot
2018-05-25 13:12 ` [PATCH v5 05/10] cpufreq/schedutil: get max utilization Vincent Guittot
2018-05-28 10:12 ` Juri Lelli
2018-05-28 14:57 ` Vincent Guittot
2018-05-28 15:22 ` Juri Lelli
2018-05-28 16:34 ` Vincent Guittot
2018-05-31 10:27 ` Patrick Bellasi
2018-05-31 13:02 ` Vincent Guittot
2018-06-01 13:53 ` Vincent Guittot
2018-06-01 17:45 ` Joel Fernandes
2018-06-04 6:41 ` Vincent Guittot
2018-06-04 7:04 ` Juri Lelli
2018-06-04 7:14 ` Vincent Guittot
2018-06-04 10:12 ` Juri Lelli
2018-06-04 12:35 ` Vincent Guittot
2018-05-29 5:08 ` Joel Fernandes
2018-05-29 6:31 ` Juri Lelli
2018-05-29 6:48 ` Vincent Guittot
2018-05-29 9:47 ` Juri Lelli
2018-05-29 8:40 ` Quentin Perret
2018-05-29 9:52 ` Juri Lelli
2018-05-30 8:37 ` Quentin Perret
2018-05-30 8:51 ` Juri Lelli
2018-05-25 13:12 ` [PATCH v5 06/10] sched: remove rt and dl from sched_avg Vincent Guittot
2018-05-25 13:12 ` [PATCH v5 07/10] sched/irq: add irq utilization tracking Vincent Guittot
2018-05-30 15:55 ` Dietmar Eggemann
2018-05-30 18:45 ` Vincent Guittot
2018-05-31 16:54 ` Dietmar Eggemann
2018-06-06 16:06 ` Vincent Guittot
2018-06-07 8:29 ` Dietmar Eggemann
2018-06-07 8:44 ` Vincent Guittot
2018-06-07 9:06 ` Dietmar Eggemann
2018-05-25 13:12 ` [PATCH v5 08/10] cpufreq/schedutil: take into account interrupt Vincent Guittot
2018-05-28 10:41 ` Juri Lelli
2018-05-28 12:06 ` Vincent Guittot
2018-05-28 12:37 ` Juri Lelli [this message]
2018-05-25 13:12 ` [PATCH v5 09/10] sched: remove rt_avg code Vincent Guittot
2018-05-25 13:12 ` [PATCH v5 10/10] proc/sched: remove unused sched_time_avg_ms Vincent Guittot
2018-06-04 16:50 ` [PATCH v5 00/10] track CPU utilization Peter Zijlstra
2018-06-04 17:13 ` Quentin Perret
2018-06-04 18:08 ` Vincent Guittot
2018-06-05 14:18 ` Peter Zijlstra
2018-06-05 15:03 ` Juri Lelli
2018-06-05 15:38 ` Patrick Bellasi
2018-06-05 22:27 ` Peter Zijlstra
2018-06-06 9:44 ` Quentin Perret
2018-06-06 9:59 ` Vincent Guittot
2018-06-06 10:02 ` Vincent Guittot
2018-06-06 10:12 ` Quentin Perret
2018-06-05 8:36 ` Vincent Guittot
2018-06-05 10:57 ` Quentin Perret
2018-06-05 11:59 ` Vincent Guittot
2018-06-05 13:12 ` Quentin Perret
2018-06-05 13:18 ` Vincent Guittot
2018-06-05 13:52 ` Quentin Perret
2018-06-05 13:55 ` Vincent Guittot
2018-06-05 14:09 ` Quentin Perret
2018-06-05 14:21 ` Quentin Perret
2018-06-05 12:11 ` Juri Lelli
2018-06-05 13:05 ` Quentin Perret
2018-06-05 13:15 ` Juri Lelli
2018-06-05 14:01 ` Quentin Perret
2018-06-05 14:13 ` Juri Lelli
2018-06-06 13:05 ` Claudio Scordino
2018-06-06 13:20 ` Quentin Perret
2018-06-06 13:53 ` Claudio Scordino
2018-06-06 14:10 ` Quentin Perret
2018-06-06 21:05 ` luca abeni
2018-06-07 8:25 ` Quentin Perret
2018-06-06 20:53 ` luca abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528123730.GC1293@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=Morten.Rasmussen@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=quentin.perret@arm.com \
--cc=rjw@rjwysocki.net \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).