linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Thomas Richter <tmricht@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
	heiko.carstens@de.ibm.com, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] perf docu: Update section on cpu topology
Date: Mon, 28 May 2018 16:54:12 -0300	[thread overview]
Message-ID: <20180528195412.GI25467@kernel.org> (raw)
In-Reply-To: <20180528074433.16652-1-tmricht@linux.ibm.com>

Em Mon, May 28, 2018 at 09:44:33AM +0200, Thomas Richter escreveu:
> Add an explanation of each cpu's core and socket
> identifier to the documentation.

Thanks, applying. I guess it is not that worth to mention that older
files may have just the string lists, right?

- Arnaldo
 
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> ---
>  tools/perf/Documentation/perf.data-file-format.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
> index d00f0d51cab8..c57904a526ce 100644
> --- a/tools/perf/Documentation/perf.data-file-format.txt
> +++ b/tools/perf/Documentation/perf.data-file-format.txt
> @@ -153,10 +153,18 @@ struct {
>  	HEADER_CPU_TOPOLOGY = 13,
>  
>  String lists defining the core and CPU threads topology.
> +The string lists are followed by a variable length array
> +which contains core_id and socket_id of each cpu.
> +The number of entries can be determined by the size of the
> +section minus the sizes of both string lists.
>  
>  struct {
>         struct perf_header_string_list cores; /* Variable length */
>         struct perf_header_string_list threads; /* Variable length */
> +       struct {
> +	      uint32_t core_id;
> +	      uint32_t socket_id;
> +       } cpus[nr]; /* Variable length records */
>  };
>  
>  Example:
> -- 
> 2.14.3

  reply	other threads:[~2018-05-28 19:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28  7:44 [PATCH] perf docu: Update section on cpu topology Thomas Richter
2018-05-28 19:54 ` Arnaldo Carvalho de Melo [this message]
2018-05-29  7:44   ` Thomas-Mich Richter
2018-05-31 10:45 ` [tip:perf/urgent] perf data: Update documentation " tip-bot for Thomas Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180528195412.GI25467@kernel.org \
    --to=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=brueckner@linux.vnet.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).