From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933739AbeE1TyT (ORCPT ); Mon, 28 May 2018 15:54:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:42634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932452AbeE1TyQ (ORCPT ); Mon, 28 May 2018 15:54:16 -0400 Date: Mon, 28 May 2018 16:54:12 -0300 From: Arnaldo Carvalho de Melo To: Thomas Richter Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, Andi Kleen Subject: Re: [PATCH] perf docu: Update section on cpu topology Message-ID: <20180528195412.GI25467@kernel.org> References: <20180528074433.16652-1-tmricht@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180528074433.16652-1-tmricht@linux.ibm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, May 28, 2018 at 09:44:33AM +0200, Thomas Richter escreveu: > Add an explanation of each cpu's core and socket > identifier to the documentation. Thanks, applying. I guess it is not that worth to mention that older files may have just the string lists, right? - Arnaldo > Signed-off-by: Thomas Richter > --- > tools/perf/Documentation/perf.data-file-format.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt > index d00f0d51cab8..c57904a526ce 100644 > --- a/tools/perf/Documentation/perf.data-file-format.txt > +++ b/tools/perf/Documentation/perf.data-file-format.txt > @@ -153,10 +153,18 @@ struct { > HEADER_CPU_TOPOLOGY = 13, > > String lists defining the core and CPU threads topology. > +The string lists are followed by a variable length array > +which contains core_id and socket_id of each cpu. > +The number of entries can be determined by the size of the > +section minus the sizes of both string lists. > > struct { > struct perf_header_string_list cores; /* Variable length */ > struct perf_header_string_list threads; /* Variable length */ > + struct { > + uint32_t core_id; > + uint32_t socket_id; > + } cpus[nr]; /* Variable length records */ > }; > > Example: > -- > 2.14.3