From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Cc: stern@rowland.harvard.edu, andrea.parri@amarulasolutions.com,
will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com,
npiggin@gmail.com, dhowells@redhat.com, j.alglave@ucl.ac.uk,
luc.maranget@inria.fr, akiyks@gmail.com, mingo@kernel.org,
torvalds@linux-foundation.org, roman.penyaev@profitbricks.com
Subject: LKMM litmus test for Roman Penyaev's rcu-rr
Date: Mon, 28 May 2018 15:08:11 -0700 [thread overview]
Message-ID: <20180528220811.GA5221@linux.vnet.ibm.com> (raw)
Hello!
The litmus test below is a first attempt to model Roman's rcu-rr
round-robin RCU-protected linked list. His test code, which includes
the algorithm under test, may be found here:
https://github.com/rouming/rcu-rr/blob/master/rcu-rr.c
The P0() process below roughly corresponds to remove_conn_from_arr(),
with litmus-test variable "c" standing in for the per-CPU ppcpu_con.
Similarly, P1() roughly corresponds to get_next_conn_rr(). It claims
that the algorithm is safe, and also claims that it becomes unsafe if
either synchronize_rcu() is removed.
Does this in fact realistically model Roman's algorithm? Either way,
is there a better approach?
Thanx, Paul
------------------------------------------------------------------------
C C-RomanPenyaev-list-rcu-rr
{
int *z=1; (* List: v->w->x->y->z. Noncircular, but long enough. *)
int *y=z;
int *x=y;
int *w=x;
int *v=w; (* List head is v. *)
int *c=w; (* Cache, emulating ppcpu_con. *)
}
P0(int *c, int *v, int *w, int *x, int *y)
{
rcu_assign_pointer(*w, y); /* Remove x from list. */
synchronize_rcu();
r1 = READ_ONCE(*c);
if (r1 == x) {
WRITE_ONCE(*c, 0); /* Invalidate cache. */
synchronize_rcu();
}
smp_store_release(x, 0); /* Emulate kfree(x). */
}
P1(int *c, int *v)
{
rcu_read_lock();
r1 = READ_ONCE(*c); /* Pick up cache. */
if (r1 == 0) {
r1 = READ_ONCE(*v); /* Cache empty, start from head. */
}
r2 = rcu_dereference(*r1); /* Advance to next element. */
smp_store_release(c, r2); /* Update cache. */
rcu_read_unlock();
/* And repeat. */
rcu_read_lock();
r3 = READ_ONCE(*c);
if (r3 == 0) {
r3 = READ_ONCE(*v);
}
r4 = rcu_dereference(*r3);
smp_store_release(c, r4);
rcu_read_unlock();
}
locations [0:r1; 1:r1; 1:r3; c; v; w; x; y]
exists (1:r1=0 \/ 1:r2=0 \/ 1:r3=0 \/ 1:r4=0) (* Better not be freed!!! *)
next reply other threads:[~2018-05-28 22:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 22:08 Paul E. McKenney [this message]
2018-05-29 18:35 ` LKMM litmus test for Roman Penyaev's rcu-rr Alan Stern
2018-05-29 19:03 ` Paul E. McKenney
2018-05-29 20:49 ` Alan Stern
2018-05-29 21:10 ` Linus Torvalds
2018-05-29 22:53 ` Paul E. McKenney
2018-05-30 14:46 ` Alan Stern
2018-05-30 14:29 ` Alan Stern
2018-05-30 14:59 ` Linus Torvalds
2018-05-30 18:10 ` Alan Stern
2018-05-30 18:38 ` Paul E. McKenney
2018-05-30 19:08 ` Alan Stern
2018-05-30 19:45 ` Paul E. McKenney
2018-05-30 20:28 ` Alan Stern
2018-05-30 21:49 ` Paul E. McKenney
2018-05-30 22:01 ` Linus Torvalds
2018-05-30 23:14 ` Paul E. McKenney
2018-05-31 14:27 ` Alan Stern
2018-06-02 14:44 ` Paul E. McKenney
2018-06-04 14:17 ` Alan Stern
2018-06-04 16:01 ` Paul E. McKenney
2018-06-06 9:40 ` Roman Penyaev
2018-06-06 13:54 ` Alan Stern
2018-06-06 14:41 ` Roman Penyaev
2018-06-06 15:55 ` Alan Stern
2018-06-06 19:07 ` Paul E. McKenney
2018-06-06 19:23 ` Linus Torvalds
2018-06-07 9:43 ` Paul E. McKenney
2018-06-07 14:57 ` Alan Stern
2018-06-07 15:40 ` Linus Torvalds
2018-06-07 15:06 ` Linus Torvalds
2018-06-07 19:57 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528220811.GA5221@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akiyks@gmail.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=j.alglave@ucl.ac.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=mingo@kernel.org \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=roman.penyaev@profitbricks.com \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).