Re: [PATCH v9 02/12] drivers: base: cacheinfo: setup DT cache properties early

Andy Shevchenko
2018-05-15T19:32:37Z

On Tue, May 15, 2018 at 8:15 PM, Jeremy Linton <jeremy.linton@arm.com> wrote:
> On 05/11/2018 06:57 PM, Jeremy Linton wrote:

>> - cache_size = of_get_property(this_leaf->of_node, propname, NULL);
>> + cache_size = of_get_property(np, propname, NULL);
>> if (cache_size)
>> this_leaf->size = of_read_number(cache_size, 1);

Can't you switch to of_read_property_uXX() variant here?

>> - line_size = of_get_property(this_leaf->of_node, propname,
>> NULL);
>> + line_size = of_get_property(np, propname, NULL);

Ditto.

>> - nr_sets = of_get_property(this_leaf->of_node, propname, NULL);
>> + nr_sets = of_get_property(np, propname, NULL);
>> if (nr_sets)
>> this_leaf->number_of_sets = of_read_number(nr_sets, 1);

Ditto.

--
With Best Regards,
Andy Shevchenko