From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@suse.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86/mce: Fix incorrect "Machine check from unknown source" message
Date: Tue, 29 May 2018 09:13:20 -0700 [thread overview]
Message-ID: <20180529161319.GA935@agluck-desk> (raw)
In-Reply-To: <20180529104222.GA19870@zn.tnic>
On Tue, May 29, 2018 at 12:42:22PM +0200, Borislav Petkov wrote:
> > + * fatal error. We call "mce_severity()" again to
> > + * make sure we have the right "msg".
> > */
> > - if (worst >= MCE_PANIC_SEVERITY && mca_cfg.tolerant < 3)
> > - mce_panic("Machine check from unknown source",
> > - NULL, NULL);
> > + if (worst >= MCE_PANIC_SEVERITY && mca_cfg.tolerant < 3) {
> > + severity = mce_severity(&m, cfg->tolerant, &msg, true);
>
> Looking at this more while cleaning the whole thing up, that severity
> doesn't get read anywhere past this line, AFAICT...
Just making the call to update "msg" (see comment). But you are right
that we don't need to update the severity variable. I'll fix that in
the re-spin to make the messages more than slightly different.
-Tony
next prev parent reply other threads:[~2018-05-29 16:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 21:40 [PATCH 0/3] x86/mce fixes Tony Luck
2018-05-25 21:41 ` [PATCH 1/3] x86/mce: Improve error message when kernel cannot recover Tony Luck
2018-06-07 20:24 ` [tip:ras/urgent] " tip-bot for Tony Luck
2018-05-25 21:41 ` [PATCH 2/3] x86/mce: Fix incorrect "Machine check from unknown source" message Tony Luck
2018-05-28 20:49 ` Borislav Petkov
2018-05-29 16:15 ` [PATCH 2/3 V2] " Luck, Tony
2018-05-29 17:41 ` Borislav Petkov
2018-05-29 17:50 ` Luck, Tony
2018-05-29 17:53 ` Borislav Petkov
2018-05-29 18:54 ` Luck, Tony
2018-05-29 20:17 ` Dan Williams
2018-05-30 9:26 ` Borislav Petkov
2018-06-19 10:30 ` Borislav Petkov
2018-05-29 18:22 ` [PATCH 2/3] " Raj, Ashok
2018-05-29 10:42 ` Borislav Petkov
2018-05-29 16:13 ` Luck, Tony [this message]
2018-06-22 12:40 ` [tip:ras/core] " tip-bot for Tony Luck
2018-05-25 21:42 ` [PATCH 3/3] x86/mce: Check for alternate indication of machine check recovery on Skylake Tony Luck
2018-06-07 17:43 ` Luck, Tony
2018-06-07 20:18 ` Dan Williams
2018-06-07 20:24 ` Borislav Petkov
2018-06-07 22:26 ` Luck, Tony
2018-06-14 21:57 ` Luck, Tony
2018-06-15 11:45 ` Borislav Petkov
2018-06-15 16:34 ` Luck, Tony
2018-06-15 17:16 ` Borislav Petkov
2018-06-07 20:24 ` Thomas Gleixner
2018-06-07 20:25 ` [tip:ras/urgent] " tip-bot for Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529161319.GA935@agluck-desk \
--to=tony.luck@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@suse.de \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox