Re: [PATCH 2/3] x86/mce: Fix incorrect "Machine check from unknown source" message

Luck, Tony
2018-05-29T16:13:22Z

On Tue, May 29, 2018 at 12:42:22PM +0200, Borislav Petkov wrote:
> > + * fatal error. We call "mce_severity()" again to
> > + * make sure we have the right "msg".
> > */
> > - if (worst >= MCE_PANIC_SEVERITY && mca_cfg.tolerant < 3)
> > - mce_panic("Machine check from unknown source",
> > - NULL, NULL);
> > + if (worst >= MCE_PANIC_SEVERITY && mca_cfg.tolerant < 3) {
> > + severity = mce_severity(&m, cfg->tolerant, &msg, true);
>
> Looking at this more while cleaning the whole thing up, that severity
> doesn't get read anywhere past this line, AFAICT...

Just making the call to update "msg" (see comment). But you are right
that we don't need to update the severity variable. I'll fix that in
the re-spin to make the messages more than slightly different.

-Tony