From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966095AbeE2SJa (ORCPT ); Tue, 29 May 2018 14:09:30 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:34392 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965678AbeE2SJ1 (ORCPT ); Tue, 29 May 2018 14:09:27 -0400 Date: Tue, 29 May 2018 14:09:26 -0400 From: Mike Snitzer To: Arnd Bergmann Cc: Alasdair Kergon , dm-devel@redhat.com, Mikulas Patocka , linux-kernel@vger.kernel.org Subject: Re: dm: writecache: fix format string warning Message-ID: <20180529180926.GC32763@redhat.com> References: <20180528155432.2864616-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180528155432.2864616-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 28 2018 at 11:54am -0400, Arnd Bergmann wrote: > The return type of ACCESS_ONCE is configuration dependent and may be either > 'int' or 'long int' for the writecache_has_error() macro, so we get a warning > like this for either format string: > > In file included from drivers/md/dm-writecache.c:8: > drivers/md/dm-writecache.c: In function 'writecache_status': > drivers/md/dm-writecache.c:2227:10: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'int' [-Werror=format=] > DMEMIT("%ld %llu %llu %llu", writecache_has_error(wc), > ^~~~~~~~~~~~~~~~~~~~ > include/linux/device-mapper.h:549:46: note: in definition of macro 'DMEMIT' > 0 : scnprintf(result + sz, maxlen - sz, x)) > ^ > > The code is otherwise correct, so we just need to shut up the warning, > which can be done using an extra type cast. > > Fixes: bb15b431d650 ("dm: add writecache target") > Signed-off-by: Arnd Bergmann Thanks, I've picked this up.