From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: okaya@codeaurora.org
Cc: Christoph Hellwig <hch@infradead.org>,
linux-pci@vger.kernel.org, timur@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Christoffer Dall <cdall@linaro.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Thymo van Beers <thymovanbeers@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
David Rientjes <rientjes@google.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Keith Busch <keith.busch@intel.com>,
Dongdong Liu <liudongdong3@huawei.com>,
Frederick Lawler <fred@fredlawl.com>,
Oza Pawandeep <poza@codeaurora.org>,
Gabriele Paoloni <gabriele.paoloni@huawei.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: Add pci=safemode option
Date: Wed, 30 May 2018 09:48:22 +0200 [thread overview]
Message-ID: <20180530074822.GB30177@kroah.com> (raw)
In-Reply-To: <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org>
On Wed, May 30, 2018 at 12:44:29AM -0700, okaya@codeaurora.org wrote:
> On 2018-05-30 00:37, Christoph Hellwig wrote:
> > On Tue, May 29, 2018 at 09:41:33PM -0700, Sinan Kaya wrote:
> > > Bjorn and I discussed the need for such a "safe" mode feature when you
> > > want to bring up PCI for a platform. You want to turn off everything
> > > as
> > > a starter and just stick to bare minimum.
> >
> > Can we please make it a config option the instead of adding code
> > to every kernel? Also maybe the bringup should be in the name
> > to make this more clear?
>
> One other requirement was to have a runtime option rather than compile time
> option.
>
> When someone reported a problem, we wanted to be able to say "use this
> option and see if system boots" without doing any bisects or recompilation.
>
> This would be the first step in troubleshooting a system to see if
> fundamental features are working.
That makes sense, people can not rebuild their kernels for the most
part. Putting it behind a config option would not make sense as it
would always have to be enabled.
> I don't mind changing the name Bjorn mentioned safe option. I made it
> safemode. I am looking at Bjorn for suggestions at this moment.
"minimal"? "basic"? "crippled"?
"my_hardware_is_so_borked_it_needs_this_option"? :)
Naming is hard...
greg k-h
next prev parent reply other threads:[~2018-05-30 7:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 3:19 [PATCH] PCI: Add pci=safemode option Sinan Kaya
2018-05-30 4:31 ` Greg Kroah-Hartman
2018-05-30 4:41 ` Sinan Kaya
2018-05-30 4:55 ` Greg Kroah-Hartman
2018-05-30 7:37 ` Christoph Hellwig
2018-05-30 7:44 ` okaya
2018-05-30 7:48 ` Greg Kroah-Hartman [this message]
2018-05-30 7:56 ` okaya
2018-05-30 8:22 ` okaya
2018-05-30 14:56 ` Bjorn Helgaas
2018-05-30 15:28 ` Sinan Kaya
2018-06-02 17:43 ` Pavel Machek
2018-06-02 17:57 ` okaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530074822.GB30177@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=cdall@linaro.org \
--cc=corbet@lwn.net \
--cc=fred@fredlawl.com \
--cc=frederic@kernel.org \
--cc=gabriele.paoloni@huawei.com \
--cc=hch@infradead.org \
--cc=kai.heng.feng@canonical.com \
--cc=keith.busch@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=marc.zyngier@arm.com \
--cc=mingo@kernel.org \
--cc=okaya@codeaurora.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=poza@codeaurora.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=thymovanbeers@gmail.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox