From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968866AbeE3Jih (ORCPT ); Wed, 30 May 2018 05:38:37 -0400 Received: from elvis.franken.de ([193.175.24.41]:48839 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965196AbeE3Jic (ORCPT ); Wed, 30 May 2018 05:38:32 -0400 Date: Wed, 30 May 2018 11:01:51 +0200 From: Tom Bogendoerfer To: Finn Thain Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net/sonic: Use dma_mapping_error() Message-ID: <20180530090151.GA2004@alpha.franken.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 30, 2018 at 01:03:51PM +1000, Finn Thain wrote: > With CONFIG_DMA_API_DEBUG=y, calling sonic_open() produces the > message, "DMA-API: device driver failed to check map error". > Add the missing dma_mapping_error() call. > > Cc: Thomas Bogendoerfer > Signed-off-by: Finn Thain > --- > drivers/net/ethernet/natsemi/sonic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c > index 7ed08486ae23..c805dcbebd02 100644 > --- a/drivers/net/ethernet/natsemi/sonic.c > +++ b/drivers/net/ethernet/natsemi/sonic.c > @@ -84,7 +84,7 @@ static int sonic_open(struct net_device *dev) > for (i = 0; i < SONIC_NUM_RRS; i++) { > dma_addr_t laddr = dma_map_single(lp->device, skb_put(lp->rx_skb[i], SONIC_RBSIZE), > SONIC_RBSIZE, DMA_FROM_DEVICE); > - if (!laddr) { > + if (dma_mapping_error(lp->device, laddr)) { > while(i > 0) { /* free any that were mapped successfully */ > i--; > dma_unmap_single(lp->device, lp->rx_laddr[i], SONIC_RBSIZE, DMA_FROM_DEVICE); > -- > 2.16.1 looks good Acked-by: Thomas Bogendoerfer Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]