Re: [PATCH v2 4/8] dt-bindings: gnss: add u-blox binding

Rob Herring
2018-05-31T03:58:11Z

On Wed, May 30, 2018 at 12:32:38PM +0200, Johan Hovold wrote:
> Add binding for u-blox GNSS receivers.
>
> Note that the u-blox product names encodes form factor (e.g. "neo"),
> chipset (e.g. "8") and variant (e.g. "q"), but that only formfactor and
> chipset is used for the compatible strings (for now).
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> .../devicetree/bindings/gnss/u-blox.txt | 44 +++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> 2 files changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gnss/u-blox.txt
>
> diff --git a/Documentation/devicetree/bindings/gnss/u-blox.txt b/Documentation/devicetree/bindings/gnss/u-blox.txt
> new file mode 100644
> index 000000000000..caef9ace0b0c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gnss/u-blox.txt
> @@ -0,0 +1,44 @@
> +u-blox GNSS Receiver DT binding
> +
> +The u-blox GNSS receivers can use UART, DDC (I2C), SPI and USB interfaces.
> +
> +Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic
> +properties.
> +
> +Required properties:
> +
> +- compatible : Must be one of

mixture of space and tab here.

> +
> + "u-blox,neo-8"
> + "u-blox,neo-m8"
> +
> +- vcc-supply : Main voltage regulator
> +
> +Required properties (DDC):
> +- reg : DDC (I2C) slave address
> +
> +Required properties (SPI):
> +- reg : SPI chip select address
> +
> +Required properties (USB):
> +- reg : Number of the USB hub port or the USB host-controller port
> + to which this device is attached
> +
> +Optional properties:
> +
> +- timepulse-gpios : Time pulse GPIO
> +- u-blox,extint-gpios : External interrupt GPIO

This should be interrupts property instead of a gpio.

> +- v-bckp-supply : Backup voltage regulator
> +
> +Example:
> +
> +serial@1234 {
> + compatible = "ns16550a";
> +
> + gnss {
> + compatible = "u-blox,neo-8";
> +
> + v-bckp-supply = <&gnss_v_bckp_reg>;
> + vcc-supply = <&gnss_vcc_reg>;
> + };
> +};
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index b5f978a4cac6..2128dfdf73f1 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -374,6 +374,7 @@ tronsmart Tronsmart
> truly Truly Semiconductors Limited
> tsd Theobroma Systems Design und Consulting GmbH
> tyan Tyan Computer Corporation
> +u-blox u-blox
> ucrobotics uCRobotics
> ubnt Ubiquiti Networks
> udoo Udoo
> --
> 2.17.0
>