Re: [PATCH RESEND v3] mtd: rawnand: ams-delta: use GPIO lookup table

Boris Brezillon
2018-07-17T20:31:35Z

+Tony

On Tue, 17 Jul 2018 19:05:52 +0200
Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote:

> Now as Amstrad Delta board - the only user of this driver - provides
> GPIO lookup tables, switch from GPIO numbers to GPIO descriptors and
> use the table to locate required GPIO pins.
>
> Declare static variables for storing GPIO descriptors and replace
> gpio_ function calls with their gpiod_ equivalents.
>
> Pin naming used by the driver should be followed while respective GPIO
> lookup table is initialized by a board init code.
>
> Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>

Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>

Just a minor comment below (nothing important, just a coding style
preference).

Also, if it goes through the omap tree (I guess it will target 4.20),
I'll need an immutable tag, because I have changes touching this driver
in the pipe (that's more a request for Tony).

> @@ -230,9 +205,42 @@ static int ams_delta_init(struct platform_device *pdev)
> platform_set_drvdata(pdev, io_base);
>
> /* Set chip enabled, but */
> - err = gpio_request_array(_mandatory_gpio, ARRAY_SIZE(_mandatory_gpio));
> - if (err)
> - goto out_gpio;
> + gpiod_nwp = devm_gpiod_get(&pdev->dev, "nwp", GPIOD_OUT_HIGH);
> + if (IS_ERR(gpiod_nwp)) {
> + err = PTR_ERR(gpiod_nwp);
> + dev_err(&pdev->dev, "NWP GPIO request failed (%d)\n", err);
> + goto out_mtd;
> + }

Can you add a blank line after each if (IS_ERR(gpiod_nwp)) { } block.

> + gpiod_nce = devm_gpiod_get(&pdev->dev, "nce", GPIOD_OUT_HIGH);
> + if (IS_ERR(gpiod_nce)) {
> + err = PTR_ERR(gpiod_nce);
> + dev_err(&pdev->dev, "NCE GPIO request failed (%d)\n", err);
> + goto out_mtd;
> + }
> + gpiod_nre = devm_gpiod_get(&pdev->dev, "nre", GPIOD_OUT_HIGH);
> + if (IS_ERR(gpiod_nre)) {
> + err = PTR_ERR(gpiod_nre);
> + dev_err(&pdev->dev, "NRE GPIO request failed (%d)\n", err);
> + goto out_mtd;
> + }
> + gpiod_nwe = devm_gpiod_get(&pdev->dev, "nwe", GPIOD_OUT_HIGH);
> + if (IS_ERR(gpiod_nwe)) {
> + err = PTR_ERR(gpiod_nwe);
> + dev_err(&pdev->dev, "NWE GPIO request failed (%d)\n", err);
> + goto out_mtd;
> + }
> + gpiod_ale = devm_gpiod_get(&pdev->dev, "ale", GPIOD_OUT_LOW);
> + if (IS_ERR(gpiod_ale)) {
> + err = PTR_ERR(gpiod_ale);
> + dev_err(&pdev->dev, "ALE GPIO request failed (%d)\n", err);
> + goto out_mtd;
> + }
> + gpiod_cle = devm_gpiod_get(&pdev->dev, "cle", GPIOD_OUT_LOW);
> + if (IS_ERR(gpiod_cle)) {
> + err = PTR_ERR(gpiod_cle);
> + dev_err(&pdev->dev, "CLE GPIO request failed (%d)\n", err);
> + goto out_mtd;
> + }
>
> /* Scan to find existence of the device */
> err = nand_scan(ams_delta_mtd, 1);