From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-479027-1527723483-2-10764527667863803919 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: linux@kroah.com X-Delivered-to: linux@kroah.com X-Mail-from: linux-security-module-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1527723483; b=fSyT2xw5LZttgUyEXM+z/endwVQhTdkLS129VgVzgA0yxJ+eyE aubuAEDxGAVOeaKE/hB7BCW4os93tuji7ZsLH6cuWsBmpSFmMWDq6ARqD1CE+8R3 KdX6Er7JHwkr0RZTVvxJ4K5RmYYTYkKmoEs8dHPUS635yKJ21S/fhcEK6tAOBZhm alT+Bv5ylDOoX3d1XOvLYeXSljTqr+G7JnohI4W9XSXg37UhUxu9ZmrqeYu/A5f2 /k6YKZlQCnfRNHe1Kq/et0uWBiYpkTcW+fEx9qplI9m1tqZwt2MtF8+9pOU0X7D4 /T98WkXc9hhsPrZz5DwoUql0SHqNOFz50HhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=fm2; t=1527723483; bh=HuvDoL7fHk1QZOhEQ4asuVTYydHVHF BHdq042Ovoj7c=; b=mQg+AV5YZGlCl2BxCBilHUkHUIndrKpkMapKXCGUoA//mN XNOgzNz7J2OeCiH5RMTS4efKRoIrgmUSintIjM6oH1wr/+NowcbD3AFg57UnCsJS /BkAqqpHcFiHs5M0q4R2gzFBRjZkUyfTLv+IX25aMq4G9DrVJ3LMsxfEvOzHg8ah ulASsTzyNoFhgnSdL2l1AaA3hekTvUuiJwp0uMd0hyhAJOiOCFu5z7uVKZiejZ3V NzmrN5WMdCvvqodDwkNeAueaOnyGWPvzrsjPN7nDPg2IcmlQrRRs3ll61rOBldKn rjlojbJ8pdCA199IHwPDQAScUUkHOJRFpnPfnTcA== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=linux.intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-security-module-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass smtp.helo=vger.kernel.org policy.ptr=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linux.intel.com header.result=pass header_org.domain=intel.com header_org.result=pass header_is_org_domain=no; x-vs=clean score=-100 state=0 Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=linux.intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-security-module-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass smtp.helo=vger.kernel.org policy.ptr=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linux.intel.com header.result=pass header_org.domain=intel.com header_org.result=pass header_is_org_domain=no; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfKz3N0vbql18UdP4ChmVwoLk50a1Gyqm8XZIiDxwMZpe1rz0iULOsp4I5EsrtXIx7H8DphZz+Y85o0bVieJK7CmP8BvqEelQBNnfZcKgatcFEKZLWJq4 TI0B55ybLaul9Y8ugr62KSUQKCIQtRCmZ9ZsL2gUWBwNhXPvDzHJSU/8Qq3n08CChF0n9cTjp+YuLfNzeEXpd8TyfsDeRTwUcslRnTP0SxnvxrP9TRXqmRgG 47xoSjl2GZjcmsjCdjaCqA== X-CM-Analysis: v=2.3 cv=NPP7BXyg c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=kj9zAlcOel0A:10 a=VUJBJC2UJ8kA:10 a=QyXUC8HyAAAA:8 a=VwQbUJbxAAAA:8 a=0BX9d-ChoBMp6uR4BisA:9 a=CjuIK1q_8ugA:10 a=x8gzFH9gYPwA:10 a=AjGcO6oz07-iQ99wixmX:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932532AbeE3Xh7 (ORCPT ); Wed, 30 May 2018 19:37:59 -0400 Received: from mga17.intel.com ([192.55.52.151]:61694 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932408AbeE3Xh6 (ORCPT ); Wed, 30 May 2018 19:37:58 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,461,1520924400"; d="scan'208";a="59062604" Date: Thu, 31 May 2018 02:37:52 +0300 From: Jarkko Sakkinen To: "Winkler, Tomas" Cc: Jason Gunthorpe , "Usyskin, Alexander" , "linux-integrity@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm Message-ID: <20180530233752.GA31296@linux.intel.com> References: <20180516194600.28189-1-tomas.winkler@intel.com> <20180522091732.GA5228@linux.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B9D89D350@hasmsx109.ger.corp.intel.com> <20180523131616.GD363@linux.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B9D8A1269@hasmsx109.ger.corp.intel.com> <20180530105034.GA14905@linux.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B9D940DC6@hasmsx108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9D940DC6@hasmsx108.ger.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: owner-linux-security-module@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, May 30, 2018 at 10:52:28AM +0000, Winkler, Tomas wrote: > > > > On Wed, May 23, 2018 at 01:48:17PM +0000, Winkler, Tomas wrote: > > > > > > > On Tue, May 22, 2018 at 09:27:46AM +0000, Winkler, Tomas wrote: > > > > > > > > > > > > On Wed, May 16, 2018 at 10:46:00PM +0300, Tomas Winkler wrote: > > > > > > > New wrappers are added tpm_cmd_ready() and tpm_go_idle() > > > > wrappers > > > > > > > to streamline tpm_try_transmit code. TPM_TRANSMIT_UNLOCKED > > > > > > > flag > > > > is > > > > > > abused > > > > > > > to resolve tpm spaces recursive calls to tpm_transmit(). > > > > > > > > > > > > This looks good and all but I don't think we want to abuse > > > > > > anything in the driver code, do we? > > > > > > > > > > It's not abuse just the flag UNLOCKED is not really named > > > > > correctly I think this has to be backported so wanted to do less invasive > > change. > > > > > > > > It should be renamed anyway and possible merge conflicts are not > > > > hard to sort out in this change. Can you rename it as SPACE? > > > > > > Not sure, I believe UNLOCKED is still better name than SPACE, I'm not > > > sure this is Do you also want to remove TPM_TRANSMIT_RAW? > > > clk_enable is handling its own anti recursion counter 'data- > > >clkrun_enabled' > > > but it should be all handled under one flag I guess. > > > > > > > Right, and even without rename this will probably cause merge > > > > conflicts at least in v4.4 an v4.9 since in-kernel RM landed in > > > > v4.12, so not much gain not do the rename :-) > > > > > > I belive we should do minimal change and the big cleanup after that. > > > Not sure, I believe UNLOCKED is still better name than SPACE even it wasn't > > the original intention. > > > No the SPACE is the issue, but any recursion call into tpm_transmit. A > > > bigger change is needed and rename to SPACE would be just another > > intermediat change. > > > > > > Please reconsider. > > > > > > Thanks > > > Tomas > > > > Reviewed-by: Jarkko Sakkinen > > > Does it mean you're Okay with the patch now? > Thanks > Tomas The change looks good but I'll have to test it. /Jarkko