From: kbuild test robot <fengguang.wu@intel.com>
To: Joel Fernandes <joelaf@google.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
kernel-team@android.com,
"Joel Fernandes (Google)" <joel@joelfernandes.org>,
Boqun Feng <boqun.feng@gmail.com>,
Byungchul Park <byungchul.park@lge.com>,
Erick Reyes <erickreyes@google.com>,
Ingo Molnar <mingo@redhat.com>, Julia Cartwright <julia@ni.com>,
linux-kselftest@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Namhyung Kim <namhyung@kernel.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Shuah Khan <shuah@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Glexiner <tglx@linutronix.de>,
Todd Kjos <tkjos@google.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: [PATCH] kselftests: fix ptr_ret.cocci warnings
Date: Thu, 31 May 2018 14:45:35 +0800 [thread overview]
Message-ID: <20180531064535.GA53792@lkp-ib04> (raw)
In-Reply-To: <20180530000500.257225-9-joel@joelfernandes.org>
From: kbuild test robot <fengguang.wu@intel.com>
lib/test_atomic_sections.c:66:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Fixes: 3b0e47f0ade1 ("kselftests: Add tests for the preemptoff and irqsoff tracers")
CC: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
test_atomic_sections.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/lib/test_atomic_sections.c
+++ b/lib/test_atomic_sections.c
@@ -63,10 +63,7 @@ static int __init atomic_sect_init(void)
snprintf(task_name, 50, "%s dis test", atomic_mode);
test_task = kthread_run((void*)atomic_sect_run, NULL, task_name);
- if (IS_ERR(test_task))
- return PTR_ERR(test_task);
-
- return 0;
+ return PTR_ERR_OR_ZERO(test_task);
}
static void __exit atomic_sect_exit(void)
next prev parent reply other threads:[~2018-05-31 6:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 0:04 [PATCH v8 0/8] Centralize and unify usage of preempt/irq tracepoints Joel Fernandes
2018-05-30 0:04 ` [PATCH v8 1/8] softirq: reorder trace_softirqs_on to prevent lockdep splat Joel Fernandes
2018-05-30 0:04 ` [PATCH v8 2/8] srcu: Add notrace variants of srcu_read_{lock,unlock} Joel Fernandes
2018-05-30 0:04 ` [PATCH v8 3/8] srcu: Add notrace variant of srcu_dereference Joel Fernandes
2018-05-30 0:04 ` [PATCH v8 4/8] trace/irqsoff: Split reset into separate functions Joel Fernandes
2018-05-30 0:04 ` [PATCH v8 5/8] tracepoint: Make rcuidle tracepoint callers use SRCU Joel Fernandes
2018-05-31 6:50 ` Mathieu Desnoyers
2018-05-31 17:51 ` Joel Fernandes
2018-06-02 1:17 ` Mathieu Desnoyers
2018-05-30 0:04 ` [PATCH v8 6/8] tracing: Centralize preemptirq tracepoints and unify their usage Joel Fernandes
2018-05-31 1:56 ` Namhyung Kim
2018-05-31 6:26 ` Joel Fernandes
2018-05-30 0:04 ` [PATCH v8 7/8] lib: Add module to simulate atomic sections for testing preemptoff tracers Joel Fernandes
2018-06-05 23:01 ` Joel Fernandes
2018-06-05 23:53 ` Joel Fernandes
2018-06-06 7:48 ` Andy Shevchenko
2018-05-30 0:05 ` [PATCH v8 8/8] kselftests: Add tests for the preemptoff and irqsoff tracers Joel Fernandes
2018-05-31 6:45 ` kbuild test robot
2018-05-31 6:45 ` kbuild test robot [this message]
2018-05-31 7:14 ` [PATCH] kselftests: fix ptr_ret.cocci warnings Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531064535.GA53792@lkp-ib04 \
--to=fengguang.wu@intel.com \
--cc=boqun.feng@gmail.com \
--cc=byungchul.park@lge.com \
--cc=erickreyes@google.com \
--cc=joel@joelfernandes.org \
--cc=joelaf@google.com \
--cc=julia@ni.com \
--cc=kbuild-all@01.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tkjos@google.com \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox