From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755579AbeEaPs7 (ORCPT ); Thu, 31 May 2018 11:48:59 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:34196 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755417AbeEaPs5 (ORCPT ); Thu, 31 May 2018 11:48:57 -0400 X-Google-Smtp-Source: ADUXVKIzaBRRBZgiMhRtpsprdiyRzV3obPFt2tIfhnBjYlIrM93pzNiEP6usBUjKefwglsPBnWuAMg== Date: Thu, 31 May 2018 08:48:54 -0700 From: Tejun Heo To: "Richard W.M. Jones" Cc: Hans de Goede , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Lorenzo Dalrio Subject: Re: [PATCH v2] libata: Drop SanDisk SD7UB3Q*G1001 NOLPM quirk Message-ID: <20180531154854.GT1351649@devbig577.frc2.facebook.com> References: <20180531112107.13778-1-hdegoede@redhat.com> <20180531121038.GR1455@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180531121038.GR1455@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 31, 2018 at 01:10:38PM +0100, Richard W.M. Jones wrote: > On Thu, May 31, 2018 at 01:21:07PM +0200, Hans de Goede wrote: > > Commit 184add2ca23c ("libata: Apply NOLPM quirk for SanDisk > > SD7UB3Q*G1001 SSDs") disabled LPM for SanDisk SD7UB3Q*G1001 SSDs. > > > > This has lead to several reports of users of that SSD where LPM > > was working fine and who know have a significantly increased idle > > power consumption on their laptops. > > > > Likely there is another problem on the T450s from the original > > reporter which gets exposed by the uncore reaching deeper sleep > > states (higher PC-states) due to LPM being enabled. The problem as > > reported, a hardfreeze about once a day, already did not sound like > > it would be caused by LPM and the reports of the SSD working fine > > confirm this. The original reporter is ok with dropping the quirk. > > > > A X250 user has reported the same hard freeze problem and for him > > the problem went away after unrelated updates, I suspect some GPU > > driver stack changes fixed things. > > > > TL;DR: The original reporters problem were triggered by LPM but not > > an LPM issue, so drop the quirk for the SSD in question. > > As the reporter of the original issue, I agree with Hans's > analysis above, so ACK from me. I'm not sure this is related but we were seeing periodic complete lockups on "SanDisk SD[78]SN*G" devices with NCQ enabled and blacklisted them for NCQ recently. Thanks. -- tejun