Re: [PATCH] MIPS: ptrace: Fix PTRACE_PEEKUSR requests for 64-bit FGRs

James Hogan
2018-05-31T21:30:55Z

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

On Wed, May 16, 2018 at 04:39:58PM +0100, Maciej W. Rozycki wrote:
> Use 64-bit accesses for 64-bit floating-point general registers with
> PTRACE_PEEKUSR, removing the truncation of their upper halves in the
> FR=1 mode, caused by commit bbd426f542cb ("MIPS: Simplify FP context
> access"), which inadvertently switched them to using 32-bit accesses.
>
> The PTRACE_POKEUSR side is fine as it's never been broken and continues
> using 64-bit accesses.
>
> Cc: <stable@vger.kernel.org> # 3.19+
> Fixes: bbd426f542cb ("MIPS: Simplify FP context access")
> Signed-off-by: Maciej W. Rozycki <macro@mips.com>
> ---
> Hi,
>
> Here's another one, spotted in the course of GDB PR gdb/22286 regression
> testing with the n64 ABI. Please apply.
>
> Maciej

Thanks, applied to mips-fixes, hopefully for 4.17 (but if it misses
tomorrows linux-next it may have to wait 'til 4.18).

Cheers
James

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]