From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751394AbeFAIl3 (ORCPT ); Fri, 1 Jun 2018 04:41:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:52052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbeFAIlX (ORCPT ); Fri, 1 Jun 2018 04:41:23 -0400 Date: Fri, 1 Jun 2018 10:41:00 +0200 From: Greg Kroah-Hartman To: James Simmons Cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , NeilBrown , Amir Shehata , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH v2 11/25] staging: lustre: libcfs: provide debugfs files for distance handling Message-ID: <20180601084100.GG19242@kroah.com> References: <1527603725-30560-1-git-send-email-jsimmons@infradead.org> <1527603725-30560-12-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527603725-30560-12-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 10:21:51AM -0400, James Simmons wrote: > From: Amir Shehata > > On systems with large number of NUMA nodes and cores it is easy > to incorrectly configure their use with Lustre. Provide debugfs > files which can help track down any issues. > > Signed-off-by: Amir Shehata > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 > Reviewed-on: http://review.whamcloud.com/18916 > Reviewed-by: Olaf Weber > Reviewed-by: Doug Oucharek > Signed-off-by: James Simmons > --- > Changelog: > > v1) Initial patch > v2) Rebased patch. No code changes from original patch > > drivers/staging/lustre/lnet/libcfs/module.c | 53 +++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/drivers/staging/lustre/lnet/libcfs/module.c b/drivers/staging/lustre/lnet/libcfs/module.c > index b438d456..d2dfc29 100644 > --- a/drivers/staging/lustre/lnet/libcfs/module.c > +++ b/drivers/staging/lustre/lnet/libcfs/module.c > @@ -468,6 +468,53 @@ static int proc_cpt_table(struct ctl_table *table, int write, > __proc_cpt_table); > } > > +static int __proc_cpt_distance(void *data, int write, > + loff_t pos, void __user *buffer, int nob) > +{ > + char *buf = NULL; > + int len = 4096; > + int rc = 0; > + > + if (write) > + return -EPERM; > + > + LASSERT(cfs_cpt_tab); What is this assert really checking? Why is it needed? thanks, greg k-h