From: Guenter Roeck <linux@roeck-us.net>
To: Colin King <colin.king@canonical.com>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (k10temp) Make function get_raw_temp static
Date: Fri, 1 Jun 2018 09:09:03 -0700 [thread overview]
Message-ID: <20180601160903.GA4178@roeck-us.net> (raw)
In-Reply-To: <20180601133713.8817-1-colin.king@canonical.com>
On Fri, Jun 01, 2018 at 02:37:13PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function get_raw_temp is local to the source and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/hwmon/k10temp.c:149:14: warning: symbol 'get_raw_temp' was not
> declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/k10temp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index d3fae5a8e508..17c6460ae351 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -146,7 +146,7 @@ static void read_tempreg_nb_f17(struct pci_dev *pdev, u32 *regval)
> F17H_M01H_REPORTED_TEMP_CTRL_OFFSET, regval);
> }
>
> -unsigned int get_raw_temp(struct k10temp_data *data)
> +static unsigned int get_raw_temp(struct k10temp_data *data)
> {
> unsigned int temp;
> u32 regval;
> --
> 2.17.0
>
prev parent reply other threads:[~2018-06-01 16:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 13:37 [PATCH] hwmon: (k10temp) Make function get_raw_temp static Colin King
2018-06-01 16:09 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601160903.GA4178@roeck-us.net \
--to=linux@roeck-us.net \
--cc=clemens@ladisch.de \
--cc=colin.king@canonical.com \
--cc=jdelvare@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox