Re: [PATCH v2 03/17] signal: make may_ptrace_stop() return bool

Christian Brauner
2018-06-01T16:00:37Z

On Fri, Jun 01, 2018 at 05:56:12PM +0200, Oleg Nesterov wrote:
> On 06/01, Christian Brauner wrote:
> >
> > may_ptrace_stop() already behaves like a boolean function. Let's actually
> > declare it as such too.
>
> OK. Then probably this patch should only make it return bool and do nothing else?
>
> > - if (unlikely(current->mm->core_state) &&
> > - unlikely(current->mm == current->parent->mm))
> > - return 0;
> > + if (likely(!current->mm->core_state ||
> > + current->mm != current->parent->mm))
> > + return false;
>
> this is wrong.

This was a suggestion by Al. I just took it over and may have messed it
up while doing so. I'll remove this.

Christian