From: Mike Snitzer <snitzer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, Krzysztof Kozlowski <krzk@kernel.org>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: dm-crypt: fix warning in shutdown path
Date: Sat, 2 Jun 2018 16:07:23 -0400 [thread overview]
Message-ID: <20180602200723.GA23980@redhat.com> (raw)
In-Reply-To: <974665e7-fa4a-230b-99d8-e773489cc6bc@kernel.dk>
On Sat, Jun 02 2018 at 4:03pm -0400,
Jens Axboe <axboe@kernel.dk> wrote:
> On 6/2/18 11:45 AM, Kent Overstreet wrote:
> > The counter for the number of allocated pages includes pages in the
> > mempool's reserve, so checking that the number of allocated pages is 0
> > needs to happen after we exit the mempool.
>
> Looks good, but needs a fixes line. I'll add one.
Also needs the subject and header updated to reflect that it fixes the
crash (Krzysztof please verify):
Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Mike Snitzer <snitzer@redhat.com>
next prev parent reply other threads:[~2018-06-02 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 17:45 [PATCH] dm-crypt: fix warning in shutdown path Kent Overstreet
2018-06-02 20:03 ` Jens Axboe
2018-06-02 20:07 ` Mike Snitzer [this message]
2018-06-02 20:10 ` Jens Axboe
2018-06-04 9:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180602200723.GA23980@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=kent.overstreet@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).