From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbeFBUH3 (ORCPT ); Sat, 2 Jun 2018 16:07:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55646 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751267AbeFBUH2 (ORCPT ); Sat, 2 Jun 2018 16:07:28 -0400 Date: Sat, 2 Jun 2018 16:07:23 -0400 From: Mike Snitzer To: Jens Axboe , Krzysztof Kozlowski Cc: Kent Overstreet , dm-devel@redhat.com, linux-kernel@vger.kernel.org Subject: Re: dm-crypt: fix warning in shutdown path Message-ID: <20180602200723.GA23980@redhat.com> References: <20180602174504.1847-1-kent.overstreet@gmail.com> <974665e7-fa4a-230b-99d8-e773489cc6bc@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <974665e7-fa4a-230b-99d8-e773489cc6bc@kernel.dk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 02 2018 at 4:03pm -0400, Jens Axboe wrote: > On 6/2/18 11:45 AM, Kent Overstreet wrote: > > The counter for the number of allocated pages includes pages in the > > mempool's reserve, so checking that the number of allocated pages is 0 > > needs to happen after we exit the mempool. > > Looks good, but needs a fixes line. I'll add one. Also needs the subject and header updated to reflect that it fixes the crash (Krzysztof please verify): Reported-by: Krzysztof Kozlowski Acked-by: Mike Snitzer