Re: [PATCH 18/33] power: supply: use match_string() helper

Sebastian Reichel
2018-05-22T16:16:26Z

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

Hi Andy,

On Tue, May 22, 2018 at 12:58:14AM +0300, Andy Shevchenko wrote:
> On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
> > match_string() returns the index of an array for a matching string,
> > which can be used intead of open coded variant.
> >
>
> This doesn't make code looks better anyhow. I even think it makes it
> worse to read. That's why I dropped my version of the change (and yes,
> I missed the type conversion which looks here just ugly).
>
> Sebastian, if my opinion makes any difference here, I would say
> NAK to this one.

I agree.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]