Re: [PATCH 31/33] ASoC: max98088: use match_string() helper

Yisheng Xie
2018-05-22T12:33:03Z

Hi Andy,

On 2018/5/22 6:24, Andy Shevchenko wrote:
> On Mon, May 21, 2018 at 2:58 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
>> match_string() returns the index of an array for a matching string,
>> which can be used intead of open coded variant.
>
>> static int max98088_get_channel(struct snd_soc_component *component, const char *name)
>> {
>
>> + int ret = match_string(eq_mode_name, ARRAY_SIZE(eq_mode_name), name);
> I would rather split this and move an assignment to the line before 'if'

hmm, you mean something like:

int ret;

ret = match_string(eq_mode_name, ARRAY_SIZE(eq_mode_name), name);
if (ret < 0) /* Shouldn't happen */
dev_err(component->dev, "Bad EQ channel name '%s'\n", name);
return ret;
>>
>> /* Shouldn't happen */
>
>> + if (ret < 0)
>> + dev_err(component->dev, "Bad EQ channel name '%s'\n", name);
>
>> return -EINVAL;
>
> return ret;
Right, sorry for this big mistake.

Thanks
Yisheng
>
> ?
>
>> }
>>
>> --
>> 1.7.12.4
>>
>
>
>