Re: [PATCH 21/33] drm/nouveau: use match_string() helper

Andy Shevchenko
2018-05-21T22:04:03Z

On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
> match_string() returns the index of an array for a matching string,
> which can be used intead of open coded variant.

> if (nouveau_tv_norm) {

> + i = match_string(nv17_tv_norm_names,
> + num_tv_norms, nouveau_tv_norm);

Same comment for logical split, 2nd parameter looks better on the previous line.

> + if (i >= 0)
> + tv_enc->tv_norm = i;
> + else
> NV_WARN(drm, "Invalid TV norm setting \"%s\"\n",
> nouveau_tv_norm);

I would rather go with

if (i < 0)
NV_WARN
else
...

> }

--
With Best Regards,
Andy Shevchenko