Re: [PATCH 07/33] iwlwifi: mvm: use match_string() helper

Andy Shevchenko
2018-05-21T21:43:34Z

On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
> match_string() returns the index of an array for a matching string,
> which can be used intead of open coded variant.

> int ret, bt_force_ant_mode;
>
> - for (bt_force_ant_mode = 0;
> - bt_force_ant_mode < ARRAY_SIZE(modes_str);
> - bt_force_ant_mode++) {
> - if (!strcmp(buf, modes_str[bt_force_ant_mode]))
> - break;
> - }
> -
> - if (bt_force_ant_mode >= ARRAY_SIZE(modes_str))

> + bt_force_ant_mode = match_string(modes_str,
> + ARRAY_SIZE(modes_str), buf);

One line?

> + if (bt_force_ant_mode < 0)
> return -EINVAL;

I would rather use

ret = match_string();
if (ret < 0)
return ret;

bt_force_... = ret;

But it's up tu Loca.

>
> ret = 0;

--
With Best Regards,
Andy Shevchenko