Re: [PATCH 01/33] usb: phy: use match_string() helper

Yisheng Xie
2018-05-22T11:13:39Z

Hi,

On 2018/5/22 18:02, Greg Kroah-Hartman wrote:
> On Tue, May 22, 2018 at 01:20:01AM +0300, Andy Shevchenko wrote:
>> On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
>>> match_string() returns the index of an array for a matching string,
>>> which can be used intead of open coded variant.
>>
>>> - int err, i;
>>> + int ret;
>>
>> int err;
>>
>> would still work.
>
> And it reduces churn.

I will keep it as err in next version.

Thanks
Yisheng
>
>