Re: [PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions

Josh Poimboeuf
2018-06-04T19:04:29Z

On Mon, Jun 04, 2018 at 04:21:24AM -0700, Nadav Amit wrote:
> +#ifdef CONFIG_STACK_VALIDATION
> +.macro ANNOTATE_UNREACHABLE counter:req
> +\counter:
> + .pushsection .discard.unreachable
> + .long \counter\()b -.
> + .popsection
> +.endm
> +
> +.macro ANNOTATE_REACHABLE counter:req
> +\counter:
> + .pushsection .discard.reachable
> + .long \counter\()b -.
> + .popsection
> +.endm
> +
> +.macro ASM_UNREACHABLE
> +999:
> + .pushsection .discard.unreachable
> + .long 999b - .
> + .popsection
> +.endm
> +#else /* CONFIG_STACK_VALIDATION */
> +.macro ANNOTATE_UNREACHABLE counter:req
> +.endm
> +
> +.macro ANNOTATE_UNREACHABLE counter:req
> +.endm
> +
> +.macro ASM_UNREACHABLE
> +.endm /* CONFIG_STACK_VALIDATION */
> +#endif

The '/* CONFIG_STACK_VALIDATION */' comment is on the wrong line.

Otherwise:

Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

--
Josh