From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752973AbeFDMN0 (ORCPT ); Mon, 4 Jun 2018 08:13:26 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:42382 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbeFDMNU (ORCPT ); Mon, 4 Jun 2018 08:13:20 -0400 Date: Mon, 4 Jun 2018 13:13:51 +0100 From: Will Deacon To: Chintan Pandya Cc: catalin.marinas@arm.com, mark.rutland@arm.com, akpm@linux-foundation.org, toshi.kani@hpe.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 3/5] arm64: pgtable: Add p*d_page_vaddr helper macros Message-ID: <20180604121351.GJ9482@arm.com> References: <1527856758-27169-1-git-send-email-cpandya@codeaurora.org> <1527856758-27169-4-git-send-email-cpandya@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527856758-27169-4-git-send-email-cpandya@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 01, 2018 at 06:09:16PM +0530, Chintan Pandya wrote: > Add helper macros to give virtual references to page > tables. These will be used while freeing dangling > page tables. > > Signed-off-by: Chintan Pandya > --- > arch/arm64/include/asm/pgtable.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 7c4c8f3..ef4047f 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -580,6 +580,9 @@ static inline phys_addr_t pgd_page_paddr(pgd_t pgd) > > #endif /* CONFIG_PGTABLE_LEVELS > 3 */ > > +#define pmd_page_vaddr(pmd) __va(pmd_page_paddr(pmd)) > +#define pud_page_vaddr(pud) __va(pud_page_paddr(pud)) Are these actually needed, or do pte_offset_kernel and pmd_offset do the job already? Will