From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2]: perf record: enable arbitrary event names thru name= modifier
Date: Mon, 4 Jun 2018 10:47:16 -0300 [thread overview]
Message-ID: <20180604134716.GD3397@kernel.org> (raw)
In-Reply-To: <20180601230100.GN30764@tassilo.jf.intel.com>
Em Fri, Jun 01, 2018 at 04:01:00PM -0700, Andi Kleen escreveu:
> On Thu, May 31, 2018 at 05:08:12PM +0300, Alexey Budankov wrote:
> >
> > Enable complex event names containing [.:=,] symbols to be encoded into Perf
> > trace using name= modifier e.g. like this:
> >
> > perf record -e cpu/name=\'OFFCORE_RESPONSE:request=DEMAND_RFO:response=L3_HIT.SNOOP_HITM\',\
> > period=0x3567e0,event=0x3c,cmask=0x1/Duk ./futex
> >
> > Below is how it looks like in the report output. Please note explicit escaped
> > quoting at cmdline string in the header so that thestring can be directly reused
> > for another collection in shell:
>
> Patch looks good, but new syntax also needs to be documented in some manpage
> (e.g. perf list)
He added the doc part in his v3 post, so I'l collecting your Acked-by,
ok?
- Arnaldo
prev parent reply other threads:[~2018-06-04 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 14:08 [PATCH v2]: perf record: enable arbitrary event names thru name= modifier Alexey Budankov
2018-06-01 8:36 ` Jiri Olsa
2018-06-01 23:01 ` Andi Kleen
2018-06-04 13:47 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604134716.GD3397@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox