From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753382AbeFDNwg (ORCPT ); Mon, 4 Jun 2018 09:52:36 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60786 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753163AbeFDNwf (ORCPT ); Mon, 4 Jun 2018 09:52:35 -0400 Date: Mon, 4 Jun 2018 15:52:31 +0200 From: Cornelia Huck To: Pierre Morel Cc: pasic@linux.vnet.ibm.com, bjsdjshi@linux.vnet.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 01/10] vfio: ccw: Moving state change out of IRQ context Message-ID: <20180604155231.42c139ac.cohuck@redhat.com> In-Reply-To: <1527243678-3140-2-git-send-email-pmorel@linux.vnet.ibm.com> References: <1527243678-3140-1-git-send-email-pmorel@linux.vnet.ibm.com> <1527243678-3140-2-git-send-email-pmorel@linux.vnet.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 May 2018 12:21:09 +0200 Pierre Morel wrote: > Let's move the state change from the IRQ routine to the > workqueue callback. > > Signed-off-by: Pierre Morel > --- > drivers/s390/cio/vfio_ccw_drv.c | 20 +++++++------------- > drivers/s390/cio/vfio_ccw_fsm.c | 14 ++++++++------ > 2 files changed, 15 insertions(+), 19 deletions(-) This causes a change in behaviour for devices in the notoper state. Now: - vfio_ccw_sch_irq is called - via the state machine, disabling the subchannel is (re-)triggered With your patch: - the work function is queued in any case; eventually, it will change the device's state to idle (unless we don't have an mdev at that point in time) - completion is signaled I'm not sure that's what we want.