From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stanislav Nijnikov <Stanislav.Nijnikov@wdc.com>
Cc: Sayali Lokhande <sayalil@codeaurora.org>,
"subhashj@codeaurora.org" <subhashj@codeaurora.org>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"vivek.gautam@codeaurora.org" <vivek.gautam@codeaurora.org>,
"rnayak@codeaurora.org" <rnayak@codeaurora.org>,
"vinholikatti@gmail.com" <vinholikatti@gmail.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"evgreen@chromium.org" <evgreen@chromium.org>,
Bart Van Assche <Bart.VanAssche@wdc.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V1 3/3] scsi: ufs: Add sysfs support for ufs provision
Date: Tue, 5 Jun 2018 10:42:00 +0200 [thread overview]
Message-ID: <20180605084200.GB8665@kroah.com> (raw)
In-Reply-To: <MWHPR04MB113794E2654BEDA8E927F0FC9A660@MWHPR04MB1137.namprd04.prod.outlook.com>
On Tue, Jun 05, 2018 at 08:16:50AM +0000, Stanislav Nijnikov wrote:
> Hi Sayali,
>
> I think that passing an array of values in a string is not proper way
> to work with a sysfs entry. There are binary attributes to do such
> things.
No, don't do that, sysfs is for "one value per file", and binary
attributes are for "hardware value pass-through" type stuff. Unless
this is "raw" data straight from the hardware, binary does not work, and
neither does a normal sysfs file either.
So this needs to be reworked please.
thanks,
greg k-h
next prev parent reply other threads:[~2018-06-05 8:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1527849774-7623-1-git-send-email-sayalil@codeaurora.org>
2018-06-01 10:42 ` [PATCH V1 1/3] scsi: ufs: set the device reference clock setting Sayali Lokhande
2018-06-01 12:29 ` Adrian Hunter
2018-06-01 13:11 ` sayali
2018-06-01 13:17 ` Adrian Hunter
2018-06-01 13:34 ` sayali
2018-06-02 5:33 ` Kyuho Choi
2018-06-05 10:48 ` sayali
2018-06-01 10:42 ` [PATCH V1 2/3] scsi: ufs: Add ufs provisioning support Sayali Lokhande
2018-06-02 6:36 ` Kyuho Choi
2018-06-05 10:54 ` sayali
2018-06-04 9:17 ` Bart Van Assche
2018-06-06 10:47 ` sayali
2018-06-01 10:42 ` [PATCH V1 3/3] scsi: ufs: Add sysfs support for ufs provision Sayali Lokhande
2018-06-01 10:49 ` sayali
2018-06-04 15:41 ` Evan Green
[not found] ` <MWHPR04MB113794E2654BEDA8E927F0FC9A660@MWHPR04MB1137.namprd04.prod.outlook.com>
2018-06-05 8:42 ` Greg Kroah-Hartman [this message]
2018-06-08 10:55 ` sayali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605084200.GB8665@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Bart.VanAssche@wdc.com \
--cc=Stanislav.Nijnikov@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=evgreen@chromium.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rnayak@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox