Re: [PATCH v5 03/10] cpufreq/schedutil: add rt utilization tracking

Vincent Guittot
2018-05-30T08:23:37Z

On 30 May 2018 at 09:03, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 25-05-18, 15:12, Vincent Guittot wrote:
>> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
>> /*
>> * Utilization required by DEADLINE must always be granted while, for
>> @@ -197,7 +205,7 @@ static unsigned long sugov_aggregate_util(struct sugov_cpu *sg_cpu)
>> * util_cfs + util_dl as requested freq. However, cpufreq is not yet
>> * ready for such an interface. So, we only do the latter for now.
>> */
>> - return min(sg_cpu->max, (sg_cpu->util_dl + sg_cpu->util_cfs));
>> + return min(sg_cpu->max, util);
>
> Need to update comment above this line to include RT in that ?

yes good point

>
>> }
>
> --
> viresh