RE: [PATCH 4.4 16/37] i2c: rcar: rework hw init

Fabrizio Castro
2018-06-25T10:05:23Z

Hello Wolfram,

What do you think about this?

Thanks,
Fab

> -----Original Message-----
> From: stable-owner@vger.kernel.org [mailto:stable-owner@vger.kernel.org] On Behalf Of Ben Hutchings
> Sent: 18 June 2018 19:47
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org; Wolfram Sang <wsa+renesas@sang-engineering.com>; Wolfram Sang <wsa@the-dreams.de>; Fabrizio
> Castro <fabrizio.castro@bp.renesas.com>; Chris Paterson <Chris.Paterson2@renesas.com>
> Subject: Re: [PATCH 4.4 16/37] i2c: rcar: rework hw init
>
> On Tue, 2018-06-05 at 19:01 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > commit 2c78cdc1c06308a59d6ed4145cdba73fdeff8c0d upstream.
> >
> > We don't need to init HW before every transfer since we know the HW
> > state then. HW init at probe time is enough.
>
> This part got reverted upstream by:
>
> commit ae481cc139658e89eb3ea671dd00b67bd87f01a3
> Author: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Date: Tue Apr 18 20:38:35 2017 +0200
>
> i2c: rcar: fix resume by always initializing registers before transfer
>
> so maybe that should go into stable (4.4 and 4.9 branches) too?
>
> Ben.
>
> > While here, add setting the
> > clock register which belongs to init HW. Also, set MDBS bit since not
> > setting it is prohibited according to the manual.
> [...]
>
> --
> Ben Hutchings, Software Developer Codethink Ltd
> https://www.codethink.co.uk/ Dale House, 35 Dale Street
> Manchester, M1 2HF, United Kingdom

Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.