From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136AbeFESwW (ORCPT ); Tue, 5 Jun 2018 14:52:22 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:37251 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbeFESwU (ORCPT ); Tue, 5 Jun 2018 14:52:20 -0400 X-Google-Smtp-Source: ADUXVKJwshZN3w2+Kb7Kr5vtweCse+VzzKaMh13g/53WV6WK+yA7vskZCbmUF+vS+7JkqXN6cn/O5Q== Date: Tue, 5 Jun 2018 11:52:16 -0700 From: Dmitry Torokhov To: Enric Balletbo i Serra Cc: Fabio Estevam , linux-kernel , Gwendal Grignou , kernel@collabora.com, linux-input@vger.kernel.org Subject: Re: [PATCH v2 5/8] Input: cros_ec_keyb - Switch to SPDX identifier. Message-ID: <20180605185216.GG202428@dtor-ws> References: <20180605175429.9072-1-enric.balletbo@collabora.com> <20180605175429.9072-6-enric.balletbo@collabora.com> <7085d0bb-557c-0796-d3ae-756e000a7950@collabora.com> <20180605182919.GF202428@dtor-ws> <776dc8b6-aa98-aeb0-320a-04294894ad2e@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <776dc8b6-aa98-aeb0-320a-04294894ad2e@collabora.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 05, 2018 at 08:45:44PM +0200, Enric Balletbo i Serra wrote: > Hi Dmitry, > > On 05/06/18 20:29, Dmitry Torokhov wrote: > > On Tue, Jun 05, 2018 at 03:16:40PM -0300, Fabio Estevam wrote: > >> Hi Enric, > >> > >> On Tue, Jun 5, 2018 at 3:14 PM, Enric Balletbo i Serra > >> wrote: > >> > >>> Right, but the module license is set to GPL which means GNU Public License v2 or > >>> later, see [1]. So, there is a mismatch. In such cases I assumed GPL-2.0+ as the > >>> default. These mismatches are common so I think that should be fine for the > >>> authors, if someone is disagree just let me know and I will change. > >> > >> Ok, but I think you should add this explanation in the commit log to > >> make it clearer. > > > > If there is a conflict between the license notice and MODULE_LICENSE() > > we should go by the license notice. The license note is usually approved > > by companies, whereas MIODULE_LICENSE()s get moved, adjusted, etc. > > > > For ChromeOS kernel changes license notice is GPL v2 as documented at: > > > > https://www.chromium.org/chromium-os/how-tos-and-troubleshooting/kernel-faq > > > > section "Which copyright header should I use?" > > > > Many thanks to share and clarify this. > > There is lots of mismatches so I'll send another version fixing this and > changing all to GPL v2. I assume I should also modify the MODULE_LICENSE when > it's wrong. I'd have a round of changes having MODULE_LICENSE() match the license notice, and then separate patches for changing over to SPDX tags. Thanks. -- Dmitry