public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Li Zefan <lizefan@huawei.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	cgroups <cgroups@vger.kernel.org>
Subject: Re: [GIT PULL] cgroup changes for v4.18-rc1
Date: Wed, 6 Jun 2018 08:04:38 -0700	[thread overview]
Message-ID: <20180606150438.GM1351649@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <CA+55aFzWdPavAPC--MY15RgwvU1QYgF+Uy7rMJmx2Dr3ddJdsQ@mail.gmail.com>

Hello, Linus.

On Tue, Jun 05, 2018 at 05:13:55PM -0700, Linus Torvalds wrote:
> On Tue, Jun 5, 2018 at 12:22 PM Tejun Heo <tj@kernel.org> wrote:
> >
> > * cgroup uses file modified events to notify certain events.  A rate
> >   limiting mechanism is added.
> 
> This "explanation" didn't really parse for me at all.
>
> I edited the merge message to something that I think is correct and
> made more sense to me.

Heh, yeah, yours reads a lot better.  Sorry about that.  The
background is that the mechanism was first added to generate
notifications on events like cgroup becoming empty, which is very low
frequency.  Since then, we've expanded its usage to cover things like
memory.high breached events which can be a lot higher frequency.

The notification implementation isn't super light weight, so the patch
ratelimits the notifications by capping minimum notification interval
interval to 10ms.

Thanks.

-- 
tejun

  reply	other threads:[~2018-06-06 15:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 19:21 [GIT PULL] cgroup changes for v4.18-rc1 Tejun Heo
2018-06-06  0:13 ` Linus Torvalds
2018-06-06 15:04   ` Tejun Heo [this message]
2018-06-06 15:14     ` Linus Torvalds
2018-06-06 15:22       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180606150438.GM1351649@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox