Re: [PATCH v3 03/12] mfd: cros_ec: Make license text and module license match.

Enric Balletbo Serra
2018-06-18T07:53:50Z

Hi Lee,
Missatge de Lee Jones <lee.jones@linaro.org> del dia dl., 18 de juny
2018 a les 9:21:
>
> On Mon, 18 Jun 2018, Lee Jones wrote:
>
> > On Wed, 06 Jun 2018, Enric Balletbo i Serra wrote:
> >
> > > The license text is specifying "GPLv2" but the MODULE_LICENSE is set to
> > > GPL which means GNU Public License v2 or later. When MODULE_LICENSE and
> > > boiler plate does not match, go for boiler plate license.
> > >
> > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > > ---
> > >
> > > Changes in v3: None
> > > Changes in v2: None
> > >
> > > drivers/mfd/cros_ec.c | 2 +-
> > > drivers/mfd/cros_ec_i2c.c | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > Applied, thanks.
>
> I've just seen Joe's comment.
>

Did you read my answer [1] to the Joe's email?

According to the doc if MODULE_LICENSE is GPL that means GPL-2.0 or
later which to be strict is wrong if your file is GPL-2.0 only. It's
right that there are modules in the kernel that have this mismatch but
IMHO is wrong, there are also some examples where people fix this, i.e
[2]

Best regards,
Enric

[1] https://lkml.org/lkml/2018/6/8/144
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75dc344145190bf53aed7a28dbc27c11180d94e5

> Unapplied, for now.
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog